From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying
 files >2GB.
In-reply-to: 
 <CAB7nPqSSq2_e4DjyR4sKgOoNGxewueF82np4EPHG8cF1tt4yLw@mail.gmail.com>
References: 
 <CA+TgmoaDdiOL4DFS07ynmfYJw5kOZwixP83G1YKoV4xRAuH-=g@mail.gmail.com>
 <20170828141631.zabmccmic7nmrel4@alvherre.pgsql>
 <CA+Tgmobzki2RY+KhvNx3MOeN4ZRyFs98yetF7T+OfHir7hh__w@mail.gmail.com>
 <CAB7nPqSSq2_e4DjyR4sKgOoNGxewueF82np4EPHG8cF1tt4yLw@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Tue, 29 Aug 2017 11:22:12 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9700.1503973584.1@sss.pgh.pa.us>
Date: Mon, 28 Aug 2017 22:26:24 -0400
Message-ID: <9701.1503973584@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> I don't like breaking the abstraction of pg_log() with the existing
> flags with some kind of pg_debug() layer. The set of APIs present now
> in pg_rewind for logging is nice to have, and I think that those debug
> messages should be translated. So what about the attached?

Your point about INT64_FORMAT not necessarily working with fprintf
is an outstanding reason not to keep it like it is.  I've not reviewed
this patch in detail but I think this is basically the way to fix it.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers