Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mf4KK-0003dj-KA for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Oct 2021 18:04:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mf4KJ-0003bb-Ip for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Oct 2021 18:04:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mf4KJ-0003Zn-AS for pgsql-hackers@lists.postgresql.org; Mon, 25 Oct 2021 18:04:03 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mf4KG-0002OP-Ob for pgsql-hackers@lists.postgresql.org; Mon, 25 Oct 2021 18:04:02 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id B8C702EAA000 for ; Mon, 25 Oct 2021 20:03:55 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id A96DA2E33EA6; Mon, 25 Oct 2021 20:03:55 +0200 (CEST) Received: from s472.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id A5ACE2C8D7D7; Mon, 25 Oct 2021 20:03:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s630.loopia.se ([172.22.191.5]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with LMTP id xgM-eEV1Onz8; Mon, 25 Oct 2021 20:03:55 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s630.loopia.se (Postfix) with ESMTPSA id 3290113ABE50; Mon, 25 Oct 2021 20:03:55 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Remove unused wait events. From: Daniel Gustafsson In-Reply-To: <20211025180122.th5rm5mhg766qd2u@alap3.anarazel.de> Date: Mon, 25 Oct 2021 20:03:54 +0200 Cc: Tom Lane , Robert Haas , Amit Kapila , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se> References: <4047667.1635179918@sss.pgh.pa.us> <4050629.1635182306@sss.pgh.pa.us> <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se> <4052153.1635183584@sss.pgh.pa.us> <20211025180122.th5rm5mhg766qd2u@alap3.anarazel.de> To: Andres Freund X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 25 Oct 2021, at 20:01, Andres Freund wrote: >=20 > On 2021-10-25 13:39:44 -0400, Tom Lane wrote: >> Daniel Gustafsson writes: >>> Since this will cause integer values to have different textual enum = value >>> representations in 14 and 15+, do we want to skip two numbers by = assigning the >>> next wait event the integer value of WAIT_EVENT_WAL_WRITE = incremented by three? >>> Or enum integer reuse not something we guarantee against across = major versions? >>=20 >> We require a recompile across major versions. I don't see a reason = why >> this particular enum needs more stability than any other one. >=20 > +1. That'd end up pushing us to be more conservative about defining = new wait > events, which I think would be bad tradeoff. Fair enough, makes sense. -- Daniel Gustafsson https://vmware.com/