From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up some code,
 comments and docs referring to Windows 2000
In-reply-to: <E1j4GrA-0006wL-WE@gemulon.postgresql.org>
References: <E1j4GrA-0006wL-WE@gemulon.postgresql.org>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 19 Feb 2020 04:21:04 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9780.1582146114.1@sss.pgh.pa.us>
Date: Wed, 19 Feb 2020 16:01:54 -0500
Message-ID: <9781.1582146114@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Clean up some code, comments and docs referring to Windows 2000 and older

Surely this patch broke the error case in haveNativeWindowsIPv6routines()?
That is, in the admittedly unlikely case that LoadLibraryA("ws2_32")
succeeds but GetProcAddress(hLibrary, "getaddrinfo") doesn't, what you
now have will do FreeLibrary(hLibrary) and then proceed to use the
now-dangling hLibrary pointer anyway.

It looks to me like you should just remove this whole stanza now:

    if (hLibrary == NULL || GetProcAddress(hLibrary, "getaddrinfo") == NULL)
    {
        /*
         * Well, ws2_32 doesn't exist, or more likely doesn't have
         * getaddrinfo.
         */
        if (hLibrary != NULL)
            FreeLibrary(hLibrary);
    }

			regards, tom lane