Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbRwG-0003QE-Ub for pgsql-committers@arkaria.postgresql.org; Sun, 12 Mar 2023 20:05:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pbRwF-0002ee-SE for pgsql-committers@arkaria.postgresql.org; Sun, 12 Mar 2023 20:05:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbRwF-0002eV-Kz for pgsql-committers@lists.postgresql.org; Sun, 12 Mar 2023 20:05:03 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbRwC-0005ww-Or for pgsql-committers@lists.postgresql.org; Sun, 12 Mar 2023 20:05:03 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 2DD3B240002; Sun, 12 Mar 2023 20:04:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------M129ZIcxBAeeeuw64we0mRgv" Message-ID: <98810acf-c2ea-ed90-2b5f-c8cfa6c1654f@dunslane.net> Date: Sun, 12 Mar 2023 16:04:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: pgsql: Add standard collation UNICODE Content-Language: en-US To: Tom Lane , Jeff Davis Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org References: <582e43d0a814e09c62ea662dd851f43bfc137a16.camel@j-davis.com> <231acf388c37597a9f0f8a3af9a899df99c28e1d.camel@j-davis.com> <1253026.1678567661@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <1253026.1678567661@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------M129ZIcxBAeeeuw64we0mRgv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-03-11 Sa 15:47, Tom Lane wrote: > Jeff Davis writes: >> On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: >>> It's fairly old: >>> $ rpm -q -a | grep icu >>>  libicu-50.2-4.0.amzn1.x86_64 >>>  libicu-devel-50.2-4.0.amzn1.x86_64 >> FWIW I tried ICU 50.2 (built from sources) and the root locale still >> sorts lowercase first. > snapper is showing this failure too [1], which makes me wonder if it's > a locally-customizable option. > > In general, I see no good reason for our regression tests to be making > assumptions about exactly how ICU's root locale behaves, so I'd suggest > just lobotomizing this test case so it doesn't depend on upper/lower > sort order. > > Yeah, I think we've found enough cases in old still not dead distros to make this reasonable. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------M129ZIcxBAeeeuw64we0mRgv Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 2023-03-11 Sa 15:47, Tom Lane wrote:
Jeff Davis <pgsql@j-davis.com> writes:
On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote:
It's fairly old:
$ rpm -q -a | grep icu
 libicu-50.2-4.0.amzn1.x86_64
 libicu-devel-50.2-4.0.amzn1.x86_64

      
FWIW I tried ICU 50.2 (built from sources) and the root locale still
sorts lowercase first.
snapper is showing this failure too [1], which makes me wonder if it's
a locally-customizable option.

In general, I see no good reason for our regression tests to be making
assumptions about exactly how ICU's root locale behaves, so I'd suggest
just lobotomizing this test case so it doesn't depend on upper/lower
sort order.

	


Yeah, I think we've found enough cases in old still not dead distros to make this reasonable.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------M129ZIcxBAeeeuw64we0mRgv--