Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGL3b-0007Nj-6J for pgsql-committers@arkaria.postgresql.org; Mon, 03 Jul 2023 15:01:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qGL3a-0007LN-3f for pgsql-committers@arkaria.postgresql.org; Mon, 03 Jul 2023 15:01:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGL3Z-0007LE-SS for pgsql-committers@lists.postgresql.org; Mon, 03 Jul 2023 15:01:37 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGL3X-001yKh-3P for pgsql-committers@lists.postgresql.org; Mon, 03 Jul 2023 15:01:37 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id E88074000F; Mon, 3 Jul 2023 15:01:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------Ca0FszQ58uh4jOlzFNpMZymh" Message-ID: <98d7edb2-cfc0-d36d-a8cf-2bf2ff8e89f8@dunslane.net> Date: Mon, 3 Jul 2023 11:01:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: pgsql: Improve pg_basebackup long file name test Windows robustness Content-Language: en-US From: Andrew Dunstan To: Daniel Gustafsson Cc: pgsql-committers@lists.postgresql.org References: <523D7BB7-53E9-46D3-A564-CEFA16C2E823@yesql.se> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------Ca0FszQ58uh4jOlzFNpMZymh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-07-03 Mo 10:51, Andrew Dunstan wrote: > > > On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote: >>> On 3 Jul 2023, at 16:08, Andrew Dunstan wrote: >>> >>> Improve pg_basebackup long file name test Windows robustness >>> >>> Creation of a file with a very long name can create problems on Windows >>> due to its file path limits. Work around that by creating the file via a >>> symlink with a shorter name. >> +dir_symlink "$pgdata", "$lftmp/pgdata"; >> >> dir_symlink doesn't exist in REL_12_STABLE. > > > Argh!. ok, thanks, will fix. > > > Neither does rel 13 have it. I've reverted all this for versions older than 14. It means running TAP tests on older version on Windows could be fragile, but at least my animals don't run TAP tests on older versions. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------Ca0FszQ58uh4jOlzFNpMZymh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2023-07-03 Mo 10:51, Andrew Dunstan wrote:


On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote:
On 3 Jul 2023, at 16:08, Andrew Dunstan <andrew@dunslane.net> wrote:

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.
+dir_symlink "$pgdata", "$lftmp/pgdata";

dir_symlink doesn't exist in REL_12_STABLE.


Argh!. ok, thanks, will fix.




Neither does rel 13 have it. I've reverted all this for versions older than 14. It means running TAP tests on older version on Windows could be fragile, but at least my animals don't run TAP tests on older versions.


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------Ca0FszQ58uh4jOlzFNpMZymh--