From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
cc: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>,
        Andres Freund <andres@anarazel.de>,
        Michael Paquier <michael@paquier.xyz>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own
 file
In-reply-to: <aKVkIUdDWvJ/MdsF@ip-10-97-1-34.eu-west-3.compute.internal>
References: <202508191517.stvm64mnl5ss@alvherre.pgsql>
 <581862.1755617245@sss.pgh.pa.us>
 <aKVkIUdDWvJ/MdsF@ip-10-97-1-34.eu-west-3.compute.internal>
Comments: In-reply-to Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
	message dated "Wed, 20 Aug 2025 05:58:57 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <990165.1755692246.1@sss.pgh.pa.us>
Date: Wed, 20 Aug 2025 08:17:26 -0400
Message-ID: <990166.1755692246@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/990166.1755692246%40sss.pgh.pa.us>
Precedence: bulk

Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote:
>> I think "make world-bin"
>> or "make install-world" are the accepted targets for building everything.

> From what I can see, only:
> check-world:
> checkprep:
> installcheck-world:
> build src/test/modules.

I agree that this does not meet the principle of least surprise.
world-bin ought to build every bit of C code we have.

> I just found surprising that a "default" make (no target specified) does not
> build src/test/modules while a "default" meson/ninja does.

In itself that observation doesn't bother me: I don't think the
conventions in the Meson world are identical to those for makefiles.
We've long expected that contrib is not included in the default
make target, and it makes sense to me for src/test/modules to work
like contrib for this purpose.

			regards, tom lane