Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1tvHsF-0037Lf-BJ
	for pgsql-committers@arkaria.postgresql.org; Thu, 20 Mar 2025 15:31:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1tvHrF-003JR5-Kx
	for pgsql-committers@arkaria.postgresql.org; Thu, 20 Mar 2025 15:30:57 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tvHrF-003JQt-DI
	for pgsql-committers@lists.postgresql.org; Thu, 20 Mar 2025 15:30:57 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tvHrD-0009Ol-2e;
	Thu, 20 Mar 2025 15:30:56 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52KFUsrS993143;
	Thu, 20 Mar 2025 11:30:54 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathan@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add vacuum_truncate configuration parameter.
In-reply-to: <E1tvHdt-0009Bj-1j@gemulon.postgresql.org>
References: <E1tvHdt-0009Bj-1j@gemulon.postgresql.org>
Comments: In-reply-to Nathan Bossart <nathan@postgresql.org>
	message dated "Thu, 20 Mar 2025 15:17:09 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <993141.1742484654.1@sss.pgh.pa.us>
Date: Thu, 20 Mar 2025 11:30:54 -0400
Message-ID: <993142.1742484654@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/993142.1742484654%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathan@postgresql.org> writes:
> Since there's presently no way to determine whether a Boolean
> storage parameter is explicitly set or has just picked up the
> default value, this commit also introduces an isset_offset member
> to relopt_parse_elt.

Uh, what?  Why is it a good idea to distinguish those states?
Seems like that risks some very surprising behavior, ie if the
default is "true", why shouldn't that act exactly like an
explicit setting of "true"?

			regards, tom lane