Message-ID: <994b40a1-af72-45d9-bfd1-9f0f4b0e9715@iki.fi>
Date: Wed, 16 Sep 2026 17:08:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Revert online data checksum transitions
To: Daniel Gustafsson <daniel@yesql.se>,
 Manuel Reyes Bravo <manuelreyesbravo@gmail.com>
Cc: Aleksander Alekseev <aleksander@tigerdata.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Masao Fujii <masao.fujii@gmail.com>
References: 
 <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
 <1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se>
 <CAJ7c6TOJnA7V7gQXa6WpdNUwtjzH+2Dd6yW8mtMO-KttPWp4+w@mail.gmail.com>
 <C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se>
 <CA+bCEdDj_Q2Fpkzm_OjUEDMrNhz1X6bsLcaDAepCaUVxT8SoZw@mail.gmail.com>
 <0FF8445C-7912-4973-94B6-936B804AC840@yesql.se>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <0FF8445C-7912-4973-94B6-936B804AC840@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/994b40a1-af72-45d9-bfd1-9f0f4b0e9715%40iki.fi>
Precedence: bulk

On 16/09/2026 16:04, Daniel Gustafsson wrote:
>> On 16 Sep 2026, at 14:58, Manuel Reyes Bravo <manuelreyesbravo@gmail.com> wrote:
> 
>> The server itself is not at risk, since PG_CONTROL_VERSION was bumped
>> and 19.0 refuses a beta3 data directory; it is only tools reading
>> archived beta3 WAL that cannot tell the formats apart.  But the revert
>> of 0d3dba38c77 on this branch (01a80f06214) bumped the magic for the
>> same reason, so it looks like this one should too.
> 
> Thanks for the report, will include when fixing.

Also, the ControlFile->data_checksum_version_init is now never set.

- Heikki