From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code
 for Wi
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
 pgsql-committers@lists.postgresql.org
References: <E1g0cYN-0003oE-IE@gemulon.postgresql.org>
 <23543.1536938575@sss.pgh.pa.us> <20180914224939.GA1178@paquier.xyz>
 <20180917114113.GA31460@paquier.xyz> <17194.1537191697@sss.pgh.pa.us>
 <20180917140202.GF31460@paquier.xyz> <19655.1537195712@sss.pgh.pa.us>
 <f62917d5-cc77-c6ac-847f-44f922ccdd97@2ndQuadrant.com>
 <3883.1537200836@sss.pgh.pa.us>
Message-ID: <99abad95-2b1a-32ea-50bb-416747fb87c4@2ndQuadrant.com>
Date: Mon, 17 Sep 2018 14:30:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <3883.1537200836@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk


On 09/17/2018 12:13 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 09/17/2018 10:48 AM, Tom Lane wrote:
>>> We've got a bit of a timing problem because we want to wrap 11beta4/rc1
>>> (still TBD) in a few hours.  I'll take a look and see if I can push a
>>> quick fix before that.
>> When you do I'll start a bowerbird run to check it.
> Pushed, please test.
>
> I think there's a general issue here of exactly how we want pgwin32_fopen
> to behave, but the immediate problem is best fixed by making pgbench deal
> with Windows newlines more thoroughly.
>
> 			


Tests are still running, but it's past the pgbench stage on HEAD, so I 
think we're good.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services