Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mstIb-0001Ay-2O for pgsql-committers@arkaria.postgresql.org; Thu, 02 Dec 2021 21:07:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mstIZ-0001WR-RU for pgsql-committers@arkaria.postgresql.org; Thu, 02 Dec 2021 21:07:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mstIZ-0001WI-KP for pgsql-committers@lists.postgresql.org; Thu, 02 Dec 2021 21:07:23 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mstIV-0001GR-Ld for pgsql-committers@lists.postgresql.org; Thu, 02 Dec 2021 21:07:23 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 37F302F08810 for ; Thu, 2 Dec 2021 22:07:18 +0100 (CET) Received: from s899.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 280002E35155; Thu, 2 Dec 2021 22:07:18 +0100 (CET) Received: from s474.loopia.se (unknown [172.22.191.5]) by s899.loopia.se (Postfix) with ESMTP id 20E7D2C8F60A; Thu, 2 Dec 2021 22:07:18 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s899.loopia.se ([172.22.191.6]) by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024) with LMTP id Dgjkvgqjhr8u; Thu, 2 Dec 2021 22:07:17 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id A218C2C8FB46; Thu, 2 Dec 2021 22:07:17 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Add TAP tests for contrib/sslinfo From: Daniel Gustafsson In-Reply-To: <20211202195130.e7pprpsx4ell22sp@alap3.anarazel.de> Date: Thu, 2 Dec 2021 22:07:17 +0100 Cc: Michael Paquier , Tom Lane , pgsql-committers@lists.postgresql.org, Andrew Dunstan Content-Transfer-Encoding: quoted-printable Message-Id: <9ABB6DDC-A3B5-45FB-9EA4-3331079C09CE@yesql.se> References: <058AAA2B-06CA-4D1C-8D24-B9EA6632C072@yesql.se> <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <1686601.1638333261@sss.pgh.pa.us> <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se> <20211202195130.e7pprpsx4ell22sp@alap3.anarazel.de> To: Andres Freund X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 2 Dec 2021, at 20:51, Andres Freund wrote: >=20 > Hi, >=20 > On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: >> Looks like perl2host() was the missing piece, fairywren turned green = with >> commit c3b34a0ff4. >=20 > Does that work with MSVC? I rebased my CI patch ontop of this, and it = fails on > windows: > https://cirrus-ci.com/task/6093088335593472?logs=3Dssl_test#L5 I was under the impression that it did, but it seems that my Appveyor = scripts had a bug which hid that =3D( Sorry for that. This seems to be another case of Perl being perfectly happy to copy and = manage the files, but Postgres not being able to read them since we'd otherwise = die() a lot sooner. The error message is the same as when the msys directory = wasn't fixed with perl2host: [04:05:47.204] # got: 'psql: error: connection to server at = "127.0.0.1", port 59360 failed: certificate present, but not private key = file "C:cirrussrctestssltmp_checktmp_test_AIn7/client.key" Looking at other tests, we pass a tempdir() to postgres just fine, so = that clearly works. The one difference here is that the filename is added = with "/client.key", so I have a feeling this is a delimiter issue where = Windows expects a backslash? In = src/test/recovery/t/025_stuck_on_old_timeline.pl we do the following, which IMO would be neat if perl2host (or a similar = function) would do for us: my $archivedir_primary =3D $node_primary->archive_dir; $archivedir_primary =3D~ s!\\!/!g if = $PostgreSQL::Test::Utils::windows_os; $node_primary->append_conf( 'postgresql.conf', qq( archive_command =3D '"$perlbin" "$FindBin::RealBin/cp_history_files" = "%p" "$archivedir_primary/%f"' wal_keep_size=3D128MB )); I'll fix it, or revert if I can't make it work. Sorry for the breakage. -- Daniel Gustafsson https://vmware.com/