Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWzKc-000209-K1 for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 11:39:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWzKb-0002qp-9D for pgsql-committers@arkaria.postgresql.org; Wed, 23 Mar 2022 11:39:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWzKb-0002o9-1u for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 11:39:13 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWzKY-0000pW-C0 for pgsql-committers@lists.postgresql.org; Wed, 23 Mar 2022 11:39:11 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 5287D240007; Wed, 23 Mar 2022 11:39:05 +0000 (UTC) Message-ID: <9cc70374-e7bf-d84a-71e6-dac97eb956cc@dunslane.net> Date: Wed, 23 Mar 2022 07:39:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Common SQL/JSON clauses Content-Language: en-US To: Tom Lane Cc: Andres Freund , pgsql-committers@lists.postgresql.org References: <20220322223319.so4ajcki7wwaujin@alap3.anarazel.de> <9fee834f-ddd9-2adb-0d6f-4ad5af92c12b@dunslane.net> <2630814.1647994125@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <2630814.1647994125@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/22/22 20:08, Tom Lane wrote: > Andrew Dunstan writes: >> On 3/22/22 18:33, Andres Freund wrote: >>> This currently triggers a number of warnings. I assume that's because of the >>> following patches not being there yet? How far out are those? >> Tomorrow, with the SQL/JSON constructors patch should resolve it. So >> roughly 24 hours. It's not his fault but this happened because Alvaro >> asked me to stagger the commits. > Sounds like all you have to do is merge this commit with the next > one in the series? Might as well do it if so. But please don't > push something that generates warnings. > > Yes, mea maxima culpa. I am working on a newer development machine than the one I have used for years and I forgot to add check_warnings to the test setup. That's remedied now. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com