Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIZWk-0002qv-RF for pgsql-committers@arkaria.postgresql.org; Tue, 24 Aug 2021 16:43:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mIZWj-0004EZ-Ov for pgsql-committers@arkaria.postgresql.org; Tue, 24 Aug 2021 16:43:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIZWj-0004EP-0Y for pgsql-committers@lists.postgresql.org; Tue, 24 Aug 2021 16:43:53 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIZWc-0001mW-Ss for pgsql-committers@lists.postgresql.org; Tue, 24 Aug 2021 16:43:52 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 2F9B732009C2; Tue, 24 Aug 2021 12:43:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 24 Aug 2021 12:43:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=noNaxG yhUOy4E19nTTjD+0HEJUGY7GQtZlmKTqWJYHk=; b=udW/wQzWRryhuHYHpfTwYU rSBREZhJIgPfP+OaUAOtKcGv3RLHnQTfplEYTFqeG4r9AmmUM7/64hXnNfDkCgPH t2Lfaj5MaI70uTUutNwyBwXg48qLxzIl6nX/p7P4LrLB63Vbu6qMzKZon7UVWz0A JS0C+KiX4AiB2r9USn2FmF4xie7taRT4HE6fCRB+4smJXvMr1OmGI/OHW/SnSkP1 on6qMWK21ghpJFeRIGvTca16QylBiNsEX1CjTCrmmwd6oDOKzkLnZlRcklAKMODv 3it/o5MNVVNocsnhhVC9jMrQlO5FCg1HGnWgfaYTvC8uk5BK8hrq1dzgrcY+3Wxw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddtjedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhffkffgfgggjtgesmhdtreertdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepffdvhfeivdehuddtiefh tdekveffhfekjeduheeiueevgeekgffgieetfefhtddunecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Aug 2021 12:43:41 -0400 (EDT) Subject: Re: pgsql: psql: Add test for query canceling To: Tom Lane , Daniel Gustafsson Cc: Fabien COELHO , pgsql-committers@lists.postgresql.org References: <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se> <1957503.1629485278@sss.pgh.pa.us> From: Peter Eisentraut Message-ID: <9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com> Date: Tue, 24 Aug 2021 18:43:38 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1957503.1629485278@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="------------4E9312C9FBBAACE7CEE66C10" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------4E9312C9FBBAACE7CEE66C10 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 20.08.21 20:47, Tom Lane wrote: > I think you should drop the overly-cute bit with a SIGALRM handler, > and instead have a loop-with-delay around an attempt to read the > psql.pid file, after launching the psql run without an immediate > wait for termination. That gets rid of the first problem (though > you still want the loop to timeout eventually, it could wait up > to say 180 seconds, as we do elsewhere). Then the second problem > is easy to solve by making the pg_sleep delay twice as much. Here is a proposal. It waits separately for the pid file to appear and also checks for the sleep query to be registered by the backend, so it doesn't have any more dependencies on things happening "fast enough". And it's also faster in the normal case now. Thoughts? --------------4E9312C9FBBAACE7CEE66C10 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Make-psql-cancel-test-more-timing-robust.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Make-psql-cancel-test-more-timing-robust.patch" RnJvbSA0ZmJhNWIxZTFiNmY2MWFjYjM1MDhiOTA4MjVjNjY4YThjNmJmNzBjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogVHVlLCAyNCBBdWcgMjAyMSAxODoyNDoxNyArMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIE1ha2UgcHNxbCBjYW5jZWwgdGVzdCBtb3JlIHRpbWluZyByb2J1c3QKCi0t LQogc3JjL2Jpbi9wc3FsL3QvMDIwX2NhbmNlbC5wbCB8IDMxICsrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA4IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90LzAyMF9jYW5jZWwucGwg Yi9zcmMvYmluL3BzcWwvdC8wMjBfY2FuY2VsLnBsCmluZGV4IDc3MTNmZmY4ZTQuLjAzMTlm NmIzZjEgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC90LzAyMF9jYW5jZWwucGwKKysrIGIv c3JjL2Jpbi9wc3FsL3QvMDIwX2NhbmNlbC5wbApAQCAtNyw2ICs3LDcgQEAKIHVzZSBQb3N0 Z3Jlc05vZGU7CiB1c2UgVGVzdExpYjsKIHVzZSBUZXN0OjpNb3JlIHRlc3RzID0+IDI7Cit1 c2UgVGltZTo6SGlSZXMgcXcodXNsZWVwKTsKIAogbXkgJHRlbXBkaXIgPSBUZXN0TGliOjp0 ZW1wZGlyOwogCkBAIC0yOCwxOSArMjksMzMgQEAKIAlteSAoJHN0ZGluLCAkc3Rkb3V0LCAk c3RkZXJyKTsKIAogCSMgVGVzdCB3aGV0aGVyIHNoZWxsIHN1cHBvcnRzICRQUElELiAgSXQn cyBwYXJ0IG9mIFBPU0lYLCBidXQgc29tZQotCSMgcHJlLS9ub24tUE9TSVggc2hlbGxzIGRv bid0IHN1cHBvcnQgaXQgKGUuZy4sIE5ldEJTRCwgU29sYXJpcykuCisJIyBwcmUtL25vbi1Q T1NJWCBzaGVsbHMgZG9uJ3Qgc3VwcG9ydCBpdCAoZS5nLiwgTmV0QlNEKS4KIAkkc3RkaW4g PSAiXFwhIGVjaG8gXCRQUElEIjsKIAlJUEM6OlJ1bjo6cnVuKFsncHNxbCcsICctWCcsICct dicsICdPTl9FUlJPUl9TVE9QPTEnXSwgJzwnLCBcJHN0ZGluLCAnPicsIFwkc3Rkb3V0LCAn Mj4nLCBcJHN0ZGVycik7CiAJJHN0ZG91dCA9fiAvXlxkKyQvIG9yIHNraXAgInNoZWxsIGFw cGFyZW50bHkgZG9lcyBub3Qgc3VwcG9ydCBcJFBQSUQiLCAyOwogCi0JbG9jYWwgJFNJR3tB TFJNfSA9IHN1YiB7Ci0JCW15ICRwc3FsX3BpZCA9IFRlc3RMaWI6OnNsdXJwX2ZpbGUoIiR0 ZW1wZGlyL3BzcWwucGlkIik7Ci0JCWtpbGwgJ0lOVCcsICRwc3FsX3BpZDsKLQl9OwotCWFs YXJtIDE7CisJIyBOb3cgc3RhcnQgdGhlIHJlYWwgdGVzdAorCW15ICRoID0gSVBDOjpSdW46 OnN0YXJ0KFsncHNxbCcsICctWCcsICctdicsICdPTl9FUlJPUl9TVE9QPTEnXSwgXCRzdGRp biwgXCRzdGRvdXQsIFwkc3RkZXJyKTsKIAotCSRzdGRpbiA9ICJcXCEgZWNobyBcJFBQSUQg PiR0ZW1wZGlyL3BzcWwucGlkXG5zZWxlY3QgcGdfc2xlZXAoMyk7IjsKLQlteSAkcmVzdWx0 ID0gSVBDOjpSdW46OnJ1bihbJ3BzcWwnLCAnLVgnLCAnLXYnLCAnT05fRVJST1JfU1RPUD0x J10sICc8JywgXCRzdGRpbiwgJz4nLCBcJHN0ZG91dCwgJzI+JywgXCRzdGRlcnIpOworCSMg R2V0IHRoZSBQSUQKKwkkc3Rkb3V0ID0gJyc7CisJJHN0ZGVyciA9ICcnOworCSRzdGRpbiA9 ICJcXCEgZWNobyBcJFBQSUQgPiR0ZW1wZGlyL3BzcWwucGlkXG4iOworCXB1bXAgJGggd2hp bGUgbGVuZ3RoICRzdGRpbjsKKwlteSAkY291bnQ7CisJdXNsZWVwKDEwXzAwMCkgdW50aWwg LXMgIiR0ZW1wZGlyL3BzcWwucGlkIiBvciAoJGNvdW50KysgPiAxODAgKiAxMDAgYW5kIGRp ZSAncGlkIGZpbGUgZGlkIG5vdCBhcHBlYXInKTsKKwlteSAkcHNxbF9waWQgPSBUZXN0TGli OjpzbHVycF9maWxlKCIkdGVtcGRpci9wc3FsLnBpZCIpOworCisJIyBTZW5kIHNsZWVwIGNv bW1hbmQgYW5kIHdhaXQgdW50aWwgdGhlIHNlcnZlciBoYXMgcmVnaXN0ZXJlZCBpdAorCSRz dGRpbiA9ICJzZWxlY3QgcGdfc2xlZXAoMTgwKTtcbiI7CisJcHVtcCAkaCB3aGlsZSBsZW5n dGggJHN0ZGluOworCSRub2RlLT5wb2xsX3F1ZXJ5X3VudGlsKCdwb3N0Z3JlcycsIHF7U0VM RUNUIChTRUxFQ1QgY291bnQoKikgRlJPTSBwZ19zdGF0X2FjdGl2aXR5IFdIRVJFIHF1ZXJ5 IH4gJ3BnX3NsZWVwJykgPiAwO30pCisJICBvciBkaWUgInRpbWVkIG91dCI7CisKKwkjIFNl bmQgY2FuY2VsIHJlcXVlc3QKKwlraWxsICdJTlQnLCAkcHNxbF9waWQ7CisKKwlteSAkcmVz dWx0ID0gZmluaXNoICRoOwogCiAJb2soISRyZXN1bHQsICdxdWVyeSBmYWlsZWQgYXMgZXhw ZWN0ZWQnKTsKIAlsaWtlKCRzdGRlcnIsIHFyL2NhbmNlbGluZyBzdGF0ZW1lbnQgZHVlIHRv IHVzZXIgcmVxdWVzdC8sICdxdWVyeSB3YXMgY2FuY2VsZWQnKTsKLS0gCjIuMzMuMAoK --------------4E9312C9FBBAACE7CEE66C10--