Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNXVV-00027s-Qk for pgsql-committers@arkaria.postgresql.org; Tue, 07 Sep 2021 09:35:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXVU-0004R3-2y for pgsql-committers@arkaria.postgresql.org; Tue, 07 Sep 2021 09:35:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNXVT-0004Qv-Q1 for pgsql-committers@lists.postgresql.org; Tue, 07 Sep 2021 09:35:07 +0000 Received: from meesny.iki.fi ([195.140.195.201]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNXVR-0007X8-6v for pgsql-committers@lists.postgresql.org; Tue, 07 Sep 2021 09:35:07 +0000 Received: from [192.168.1.113] (dsl-hkibng22-54faa4-119.dhcp.inet.fi [84.250.164.119]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by meesny.iki.fi (Postfix) with ESMTPSA id 8C55920693; Tue, 7 Sep 2021 12:35:03 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1631007303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aGgkrkk9z3OYtdLvOgCE2G7/+LvJIGtCIHrUcjKPNAc=; b=l7o+EvwpfBqSl5w2A4j60FdN1dP9dRseMDYrjFNueoP9YJZ16BXVGlDdNeqRzjJnP69amb /2I0XlwdNr4z3ZN5FwL2Gw4gWB3z9t/6UWl6mt2NVarZP5uBEo6P3G+Z3xu0lT4vi5R5ZP iNbEmoxloPnb4i74gTFERMNfHXRh18M= Subject: Re: pgsql: Fix segfault during EvalPlanQual with mix of local and foreign p To: Amit Langote Cc: pgsql-committers@lists.postgresql.org References: From: Heikki Linnakangas Message-ID: <9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi> Date: Tue, 7 Sep 2021 12:35:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=meesny; d=iki.fi; t=1631007303; a=rsa-sha256; cv=none; b=aQOyHMiCVU9aHc7WjJIVrqYOPrWnuvQRRY9r36Y1nEQ25KbTYIUmEm7wCRAYFDDtaNoYWa nvdbFhXJHVP6I8bPsmZqUeJPkYigMBpGw0qDxxdcAkw9fST7z9xoEoSFXD0rTlfcoYtIZj F52LnaiioADeKCExHqrkRKUOvO7bcew= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1631007303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aGgkrkk9z3OYtdLvOgCE2G7/+LvJIGtCIHrUcjKPNAc=; b=pFvdRb9VvZzU1GoCLFlbbmTnCrg2WrW6H/zlEXRiHoTMQrfhVJHpCz/0V5S4DrtfKg3RTv 3Fq6SyKakZVdfx2INs+gcoamiGdG9jJ3C7+sKB4lyIOjPJMCwkYhiQXjy6234bWiBGK9Nm CF1CiVm97idNg0FMSKodoQIBdj4N8fM= List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 06/09/2021 11:50, Amit Langote wrote: > Quite late but to I was looking at this and noticed this comment: > > + /* > + * Direct modifications cannot be re-evaluated by EvalPlanQual, so > + * don't bother preparing the FDW. There can ForeignScan nodes in the > + * EvalPlanQual subtree, but ExecForeignScan should never be called. > + */ > > The 2nd sentence seems to be missing a "be" between "can" and > "ForeignScan". Also, does it mean the following? > > "There can be ForeignScan nodes in the EvalPlanQual plan subtree, but > ExecForeignScan should never be called on them [during EvalPlanQual]." > > I've attached a patch that changes the text like that. Applied, thanks! - Heikki