Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbrT-00059G-SJ for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 17:11:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZbrS-0003AD-Gf for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 17:11:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbrS-00039y-7V for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 17:11:58 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbrQ-0003Bq-81 for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 17:11:57 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id AA9F13201F86; Wed, 30 Mar 2022 13:11:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 30 Mar 2022 13:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=r0Xj4uDF3IT4Ld yc/nKG+c/hAxSRNz9gt82i9epWZF8=; b=FrfGJR00Tj5Kel/7FZzBB0r93L7BV0 bGfbssKvbFgcJjhwBZYoQ9qREMpzMWJcgnF/R7CzMM7Ai9PIoCC2A9aNqfn32/S9 1ZBiyrvtTTa6EuqTEIUf1rIEPdu9NNXNfdNplvYg0R8zCiaCBWYJmbRF99sXlVEC YceVn7L1F/iknVKY296ljnDuMI/1SHGcBpOFEj6aYaoFKGXi7QRXoACUMTXDdV8z tdeTPrz4Z6vxcWr+1/DVRylbX1YoK2s31rJFt7hYIyaBZvuLe1GfrQpeB8EYbBbQ a/4umQ+8hF5n+iQVYXos8tVl9Pm1L58Bt9GcvFZGWDreDwc9SKMfi+9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=r0Xj4uDF3IT4Ldyc/nKG+c/hAxSRNz9gt82i9epWZ F8=; b=O1Z3v95NVy1r9KGt4nLFgi6MhfT6DjgmHbNAZIhhD6DcCBdHggmL9ejlY AwkQ52fxmY5L0ekfEYQU68DlTm2vG0CAuGkOWcADXjxjgaB+ekXsVHhElQbB6Hao eva+Pb05xNjiUGedkLeEmYFSNap0lElsJQZ/hh9zIY8A4SXJLbhqhJkwV820uUY0 IXbjJWjhL5LKHN9CRVvAz/73MjeaIoqspYXl82pJAZtqEPSwWpNcQlfkZeuTS3Rp xRD6bHzZL22cDnrjNUwrrwIMfAa21v3mg5UXcMKEO6rV/SceJNCp3INcbvdcmwTq LXw9mz+n6rtGgK2TGGOt4TNpQsCTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeivddguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvufgfjghfkfggtgfgsehtqhhmtddtreejnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpeeftddthfelhfefheehkeejgeehfeehvdfhgfdtieevudegveekleef gfdvgeehvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Mar 2022 13:11:51 -0400 (EDT) Date: Wed, 30 Mar 2022 10:11:49 -0700 From: Andres Freund To: Tom Lane CC: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. User-Agent: K-9 Mail for Android In-Reply-To: <230838.1648659506@sss.pgh.pa.us> References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi,=20 On March 30, 2022 9:58:26 AM PDT, Tom Lane wrote= : >Andres Freund writes: >> Random aside: Am I the only one bothered by a bunch of places in >> Makefile=2Eglobal=2Ein quoting like >> $(MAKE) -C '$(top_builddir)' DESTDIR=3D'$(abs_top_builddir)'/tmp_inst= all install >'$(abs_top_builddir)'/tmp_install/log/install=2Elog 2>&1 >> and >> rm -rf '$(CURDIR)'/tmp_check && >> etc > >Don't we need that to handle, say, build paths with spaces in them? My concern is about the quote in the middle of the path, not about quoting= at all=2E=2E=2E I=2Ee=2E the ' should be after /tmp_install, not before=2E >Admittedly we're probably not completely clean for such paths, >but that's not an excuse to break the places that do it right=2E > >(I occasionally think about setting up a BF animal configured >like that, but haven't tried yet=2E) That might be a fun exercise=2E Not so much for the build aspect, but to m= ake sure our tools handle it=2E Andres --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E