DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=ff6dcNy3mtAod9l2VPcqgvIfKwu/HLp1n9T0HwaADWUWpQ3KJpOnMn8HNFm/u9AfJe
	4hv9AHFZhrY60hsVbmSzOgp2KJ1Zh4d+6kzGRxF9Q6/zGiFafaaRhxraTC9qsARd5o6+
	99vn/HzB2oLkHs52bq8lTUL4zF9oNBWXkE14o=
MIME-Version: 1.0
In-Reply-To: <1299489607.1696.7933.camel@ebony>
References: <E1PwMns-00047O-UU@gemulon.postgresql.org>
	<AANLkTikJmP+bo1N-mFUWEpJiV6_OKisYw512OGeTJUbm@mail.gmail.com>
	<1299489607.1696.7933.camel@ebony>
Date: Mon, 7 Mar 2011 18:28:25 +0900
Message-ID: <AANLkTimDNqnzPdMji20RW09UfA1KHpPEMdbCkE9jKW-C@mail.gmail.com>
Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous
	replication.
From: Fujii Masao <masao.fujii@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Mar 7, 2011 at 6:20 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Mon, 2011-03-07 at 17:27 +0900, Fujii Masao wrote:
>> On Mon, Mar 7, 2011 at 7:51 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>
>> And,, I found one bug ;) You seem to have wrongly removed the check
>> of max_wal_senders in SyncRepWaitForLSN. This can make the
>> backend wait for replication even if max_wal_senders = 0. I could produce
>> this problematic situation in my machine. The attached patch fixes this problem.
>
> There may be a bug, but that's not the fix.
>
> I spotted that issue myself in testing. I put in a protection to stop
> setting synchronous_standby_names if max_wal_senders is zero, with error
> message.
>
> Are you saying the committed version doesn't trigger that ERROR?

I changed synchronous_standby_names after startup and reloaded the
configuration file. So I didn't encounter such an error message.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center