Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYZQt-0007fy-Bf for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 19:51:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYZQs-0001Li-Ab for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 19:51:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYZQs-0001La-2e for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 19:51:58 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYZQn-0003jE-D2 for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 19:51:57 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 753DB2E9E8C6 for ; Thu, 7 Oct 2021 21:51:50 +0200 (CEST) Received: from s499.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 65F362E2A248; Thu, 7 Oct 2021 21:51:50 +0200 (CEST) Received: from s473.loopia.se (unknown [172.22.191.6]) by s499.loopia.se (Postfix) with ESMTP id 6081C1CE64B0; Thu, 7 Oct 2021 21:51:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.5]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id AGEfCG4AaSlM; Thu, 7 Oct 2021 21:51:50 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id DE1117CEB34; Thu, 7 Oct 2021 21:51:49 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. From: Daniel Gustafsson In-Reply-To: <173186.1633635888@sss.pgh.pa.us> Date: Thu, 7 Oct 2021 21:51:49 +0200 Cc: Postgres hackers , Craig Ringer , Noah Misch Content-Transfer-Encoding: quoted-printable Message-Id: References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> To: Tom Lane X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 7 Oct 2021, at 21:44, Tom Lane wrote: >=20 > [ cc'ing Craig and Noah, as author/committer of the existing text ] >=20 > Daniel Gustafsson writes: >> On 7 Oct 2021, at 21:02, Tom Lane wrote: >>> BTW, looking at that a second time, I wonder if that advice is >>> really of any use. >=20 >> Yeah, I would have to agree. Reading that again I think what it = perhaps should >> be saying is that 5.8.3 is the Perl API level that the testcode must = conform >> to, but they should run with basically whichever recent Perl you have = handy as >> long as the required modules are installed. Not that we expect = developers to >> run 5.8.3 when executing TAP tests. >=20 > Yeah. I propose that what might be more useful than the existing last > section of src/test/perl/README is something along the lines of: >=20 > Avoid using any bleeding-edge Perl features. We have buildfarm > animals running Perl versions as old as 5.8.3, so your tests will > be expected to pass on that. >=20 > Also, do not use any non-core Perl modules except IPC::Run. > Or, if you must do so for a particular test, arrange to skip > the test when the needed module isn't present. Agreed, that's a lot more helpful. Since the set of core Perl modules = change over time as modules are brought in (at least that's my understanding of = it), that last paragraph might want to discourage use of modules that aren't expected to be in-core in commonly used systems? It might be = overthinking it though. -- Daniel Gustafsson https://vmware.com/