Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZjkl-00033k-45 for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 01:37:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZjkk-000560-18 for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 01:37:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZjkj-00055b-MK for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 01:37:33 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nZjkh-0005wW-35 for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 01:37:32 +0000 Received: by mail-qk1-x736.google.com with SMTP id p25so18643875qkj.10 for ; Wed, 30 Mar 2022 18:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=S6W0MteHHWW/kL4KQzfvHOp3tYZf9+ZQJx2iBtZOKoo=; b=xbPPXfPxlgfCCvGk85c+AWmbxfQ7dSLt25c+TuVCp3Cbmg1wnVaif9W0UxZWOiXPE1 aU5ne8kUOxd393IOtGlEXS+HqTd/2Q5W9VW3xIl5V43a5NXXbF8vVkDXNv0IzeQBY0TR 85PeMMI78uFkazzQVcqja9olnv5qrtn1KghEZw6aP39TnhHPYufcMcDqfaPPqDKGn/Rq QtYQVE7S7Kc9YESLcy8QRpyf8sWpVRQT3lR32fFAPPyeaZ5iMeuapeLBNGh1yIwPLqyf AAaShj6O04d1Wt8CRnV7+XfBf4bRT29V8T8FiMG9CbBpmA4mjm/F9VvdMlR6IK1AKtuY DJUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=S6W0MteHHWW/kL4KQzfvHOp3tYZf9+ZQJx2iBtZOKoo=; b=El2qTN/q28rx/jyXL2dnXlu/Ks0t933FXs9H4/6AeYGPoKc4E9rHGImkKR5XPJF7Yd OWpRNJ0JHQhGVxmMQCI0HJoycw6X6eJLxgDBCM4L8nigt6AYENgT3MfbPArw6xHbPv/U 7JB5zk4IjE6R+K3uNRWRQRPIYoUPTOz6QD7bz2c2dh+4cCEUNyIpX/jGRnWdBT5pA/9P FVL1+196yLpSctp2oC8hbYA9fNoFrz7D3bWP4urh+33b9xn7OV6xFZIGwqpjwQnHWJJf KN0kQqFWXdXPF41wocFmXs4n6iyK7XIyJ+3qxVK6zUFGuhCxCUl1tuplYq8EO4qNwZ// YHHA== X-Gm-Message-State: AOAM531A4n0HSHpuhiUoKAZXdthjogApaTmNvnl1Vo1H9Vqit0aBA01C EYWUwASbXPo8I9Mqfj1JnvCtcg== X-Google-Smtp-Source: ABdhPJxK7iM8+IbQMLglTXFyYImyaMv8E2PvorYCGWvmSoHJnYXR0pkXOZIr5hu0e4dHBEH8nQAaCQ== X-Received: by 2002:a05:620a:5e:b0:67d:323c:a1fc with SMTP id t30-20020a05620a005e00b0067d323ca1fcmr1789905qkt.675.1648690649522; Wed, 30 Mar 2022 18:37:29 -0700 (PDT) Received: from smtpclient.apple ([2600:1004:b08d:5930:b57f:7108:9552:a6cc]) by smtp.gmail.com with ESMTPSA id v5-20020a05622a144500b002e1c7d027b1sm17925161qtx.66.2022.03.30.18.37.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 18:37:29 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-27017D6C-B922-40D1-81EE-48E95229DEF8 Content-Transfer-Encoding: 7bit From: Andrew Dunstan Mime-Version: 1.0 (1.0) Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches Date: Wed, 30 Mar 2022 21:37:27 -0400 Message-Id: References: <479467.1648689140@sss.pgh.pa.us> Cc: pgsql-committers@lists.postgresql.org In-Reply-To: <479467.1648689140@sss.pgh.pa.us> To: Tom Lane X-Mailer: iPad Mail (19D52) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail-27017D6C-B922-40D1-81EE-48E95229DEF8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > On Mar 30, 2022, at 9:12 PM, Tom Lane wrote: >=20 > =EF=BB=BFAndrew Dunstan writes: >>>> On Mar 30, 2022, at 8:19 PM, Tom Lane wrote: >>> I think this means that its old Perl version misinterprets >>> use parent -norequire, qw(PostgreSQL::Test::Cluster); >>> as a request to include "parent.pm". Is there a more >>> backwards-compatible way to spell that? >=20 >> Not that I know of. Googling tells me it was a core module from 5.10.1. I= can revert tomorrow if necessary :-( >=20 > Hmm. I checked not too long ago, and these are the buildfarm > animals that would be broken: >=20 > prairiedog | 2022-03-23 05:04:02 | configure: using perl 5.8.3 > anole | 2022-03-24 10:40:08 | configure: using perl 5.8.8 > gharial | 2022-03-24 18:32:22 | configure: using perl 5.8.8 > locust | 2022-03-19 22:17:53 | configure: using perl 5.8.8 > gaur | 2022-03-19 15:00:54 | configure: using perl 5.8.9 >=20 > I could update prairiedog and gaur (... probably), but hard to say > about the others. >=20 > It seems kind of sad for a backwards-compatibility patch to force a > major move of our minimum Perl version. OTOH, if there's no other > good way to do it, maybe we gotta. >=20 > Another possibility is that maybe parent.pm could be successfully > installed into a 5.8.x installation. I can't speak for those > other animals, but mine at least are already frankencritters. >=20 >=20 I think it can be salvaged. See https://fastapi.metacpan.org/source/CORION/p= arent-0.238/lib/parent.pm Cheers Andrew= --Apple-Mail-27017D6C-B922-40D1-81EE-48E95229DEF8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Mar 30, 2022, at 9:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote= :

=EF=BB= =BFAndrew Dunstan <andrew@dunslane.net> writes:
On Mar 30, 2022, at 8:19= PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I think thi= s means that its old Perl version misinterprets
use parent= -norequire, qw(PostgreSQL::Test::Cluster);
as a request t= o include "parent.pm".  Is there a more
backwards-com= patible way to spell that?
=
Not that I know of. Googling tells me it= was a core module from 5.10.1. I can revert tomorrow if necessary :-(

Hmm.  I checked not too long a= go, and these are the buildfarm
animals that would be broken= :

prairiedog    | 2022-03-2= 3 05:04:02 | configure: using perl 5.8.3
anole   =       | 2022-03-24 10:40:08 | configure: using= perl 5.8.8
gharial       | 2= 022-03-24 18:32:22 | configure: using perl 5.8.8
locust &nb= sp;      | 2022-03-19 22:17:53 | configure: us= ing perl 5.8.8
gaur       &nb= sp;  | 2022-03-19 15:00:54 | configure: using perl 5.8.9
I could update prairiedog and gaur (... probably), b= ut hard to say
about the others.

= It seems kind of sad for a backwards-compatibility patch to force a
major move of our minimum Perl version.  OTOH, if there's= no other
good way to do it, maybe we gotta.

Another possibility is that maybe parent.pm could be succe= ssfully
installed into a 5.8.x installation.  I can't s= peak for those
other animals, but mine at least are already f= rankencritters.




Cheers

Andrew
= --Apple-Mail-27017D6C-B922-40D1-81EE-48E95229DEF8--