Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: pgsql: Remove the adminpack contrib extension
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <3690275.1709570049@sss.pgh.pa.us>
Date: Mon, 4 Mar 2024 20:08:16 +0100
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 pgsql-committers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B5FC1FD8-01ED-4C22-BE98-8D483000E331@yesql.se>
References: <202403041527.k2fsmwdgf6fy@alvherre.pgsql>
 <0D569522-B87D-4178-A15E-9751905614EF@yesql.se>
 <3690275.1709570049@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/B5FC1FD8-01ED-4C22-BE98-8D483000E331%40yesql.se>
Precedence: bulk

> On 4 Mar 2024, at 17:34, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Daniel Gustafsson <daniel@yesql.se> writes:
>> I see that my fix didn't solve it for 11 and 9.x on crake and drongo, =
will
>> rebuild more old trees and test to find the correct fix.
>=20
> The oldest branches didn't make that DB, so you need an "IF EXISTS".
> I pushed a fix after quickly checking it here.

Thanks for fixing, much appreciated!

The deviation between database names on crake found in the follow-up =
commit is
a bit concerning.  Too much magic hidden away from the codetree makes it =
hard
to get tests right on the first try.

--
Daniel Gustafsson