Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YvOrH-0004iR-82 for pgsql-hackers@arkaria.postgresql.org; Thu, 21 May 2015 11:41:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YvOrF-0005kA-Ui for pgsql-hackers@arkaria.postgresql.org; Thu, 21 May 2015 11:41:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YvOrE-0005k3-8n for pgsql-hackers@postgresql.org; Thu, 21 May 2015 11:41:48 +0000 Received: from mail-vn0-x233.google.com ([2607:f8b0:400c:c0f::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1YvOr6-0003fn-Px for pgsql-hackers@postgresql.org; Thu, 21 May 2015 11:41:46 +0000 Received: by vnbf129 with SMTP id f129so5704597vnb.1 for ; Thu, 21 May 2015 04:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=WUlpi82+tYfSWaYQhdvKVAml3B5FVlRR9d3JVbCXyXU=; b=TKHuiVn8+dWxBGCVKJAUyznOH7hl8p3ln5M5VySsxKYiGXCvmBLZjPB4NKIsQIg5Wc UEXijtwWyh1wFHQhrBbmaH40V16BFJh1z8pjJ5avr0fQPxQyNbkVSYspP+vPbeh0lkst LXOpF6iJhHdXolj9KapvrUUZU4CwyMNtuG6ss9RXsKPTqOIgqgykiGNLQ7+vwI6JhnIL r4ypCOB4IT+LLAb4tVmdbEtwB5I3eV5My4Y4piW5CBf6FiNexSucpZh6z77xbGvWuy/J R2FFhVbfTVjKlcO7CHg8xJtuAKxTNcElVQfqO+ZVpof6AzwCcKL84WENwlJm1GoWj1p1 rjng== X-Received: by 10.52.139.168 with SMTP id qz8mr1877031vdb.82.1432208499812; Thu, 21 May 2015 04:41:39 -0700 (PDT) Received: from [192.168.1.4] (pool-108-24-155-230.cmdnnj.fios.verizon.net. [108.24.155.230]) by mx.google.com with ESMTPSA id j9sm5174648vdi.28.2015.05.21.04.41.38 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 21 May 2015 04:41:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. From: Robert Haas X-Mailer: iPad Mail (12F69) In-Reply-To: <10660.1432171328@sss.pgh.pa.us> Date: Thu, 21 May 2015 07:41:37 -0400 Cc: Andres Freund , Peter Geoghegan , Alvaro Herrera , Pg Hackers Content-Transfer-Encoding: 7bit Message-Id: References: <20150520215816.GI5885@postgresql.org> <20150520220911.GK5885@postgresql.org> <20150521011229.GX27868@alap3.anarazel.de> <10660.1432171328@sss.pgh.pa.us> To: Tom Lane X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On May 20, 2015, at 9:22 PM, Tom Lane wrote: > Andres Freund writes: >> You realize there's other instances of this in the same damn function? > > Not to mention that several places in libpq/fe-exec.c should be > taught about this new tag. And who-knows-what in other client-side > libraries. I am not really sure that it was a good idea to invent > this command tag. In fact, I'm pretty sure it was a *bad* idea --- > what will happen if we ever create a statement actually named UPSERT? > > I think we should fix this by ripping out the variant tag, not trying > to propagate it everywhere it would need to go. +1 ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers