Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tj3eY-005Upo-Qg for pgsql-committers@arkaria.postgresql.org; Fri, 14 Feb 2025 21:55:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tj3eW-00ELY1-LG for pgsql-committers@arkaria.postgresql.org; Fri, 14 Feb 2025 21:55:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tj3eW-00ELXt-E7 for pgsql-committers@lists.postgresql.org; Fri, 14 Feb 2025 21:55:16 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tj3eT-000seS-2z for pgsql-committers@lists.postgresql.org; Fri, 14 Feb 2025 21:55:16 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id C08BD29F75C for ; Fri, 14 Feb 2025 22:55:12 +0100 (CET) Received: from s979.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id AAB672A0471; Fri, 14 Feb 2025 22:55:12 +0100 (CET) Received: from s473.loopia.se (unknown [172.22.191.6]) by s979.loopia.se (Postfix) with ESMTP id A85D210BC476; Fri, 14 Feb 2025 22:55:12 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s473.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s899.loopia.se ([172.22.191.5]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id vcOGMRu9hixb; Fri, 14 Feb 2025 22:55:12 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id 2F5352C8BA56; Fri, 14 Feb 2025 22:55:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1739570112; bh=QkVSIx3ahvyCuhuSexsxTNo7tp+hacDmgf3WmHezr8o=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=SPqKUat5TWeYkRcWdhIoEtSbPH/jf1YyEGOmfDJYVdzJEk9gEeUiSf7oGzswPImnK YgrW59fQj7ub/HJ0wrEshcUxBd83nNOtjwy0gd/+s6QGClFQDapvKvq3L4LVYd4oUd LxBzVziaqtzfLsJ296wFkzaHDcvaMSW9krjnqRFEtHLQP2KWh+Jn8tkrKcW1qFHQV2 oPAbgC+4ojssReFrwl3QipNVKlODMC8qhdMtnXyFwjV67iwydPuvmFCSfT45pXQACH uvUFHzQGn9Sy6mmtMO7LFfPGtgqfS5OeLlmHRZxdpZHPv3rbwrNz9rS6F8EuXyrZM3 4YV4etOFFuHEA== Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags From: Daniel Gustafsson In-Reply-To: Date: Fri, 14 Feb 2025 22:55:01 +0100 Cc: pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Melanie Plageman X-Mailer: Apple Mail (2.3776.700.51.11.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 14 Feb 2025, at 22:41, Melanie Plageman = wrote: >=20 > On Fri, Feb 14, 2025 at 3:45=E2=80=AFPM Daniel Gustafsson = wrote: >>=20 >>> On 14 Feb 2025, at 18:59, Melanie Plageman = wrote: >>>=20 >>> Convert heap_vac_scan_next_block() boolean parameters to flags >>=20 >> This seems to have made skink upset with a Valgrind error: >>=20 >> = https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dskink&dt=3D2025-= 02-14%2020%3A30%3A29 >=20 > Yep. Thanks. I replied to one of the other commits -- valgrind is mad > at two of them. Yeah, I noticed that after I had replied since I first went looking at = the wrong threads, sorry for the noise. -- Daniel Gustafsson