Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miLvB-0001Qv-Nr for pgsql-committers@arkaria.postgresql.org; Wed, 03 Nov 2021 19:27:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1miLv9-0003Gs-VL for pgsql-committers@arkaria.postgresql.org; Wed, 03 Nov 2021 19:27:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miLv9-0003Gc-Ot for pgsql-committers@lists.postgresql.org; Wed, 03 Nov 2021 19:27:39 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miLv5-0004Xj-My for pgsql-committers@lists.postgresql.org; Wed, 03 Nov 2021 19:27:39 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 6ABB72EABA26 for ; Wed, 3 Nov 2021 20:27:34 +0100 (CET) Received: from s934.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 5BC242E2B964; Wed, 3 Nov 2021 20:27:34 +0100 (CET) Received: from s470.loopia.se (unknown [172.22.191.5]) by s934.loopia.se (Postfix) with ESMTP id 5A0237D1B0A; Wed, 3 Nov 2021 20:27:34 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.5]) by s470.loopia.se (s470.loopia.se [172.22.190.10]) (amavisd-new, port 10024) with LMTP id xDuuyIi2jLhu; Wed, 3 Nov 2021 20:27:34 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.144] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id 030AB7D1AB6; Wed, 3 Nov 2021 20:27:33 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails. From: Daniel Gustafsson In-Reply-To: Date: Wed, 3 Nov 2021 20:27:33 +0100 Cc: pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Heikki Linnakangas X-Mailer: Apple Mail (2.3608.120.23.2.7) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 3 Nov 2021, at 18:47, Heikki Linnakangas wrote: >=20 > On 03/11/2021 13:06, Daniel Gustafsson wrote: >>> On 3 Nov 2021, at 10:44, Heikki Linnakangas = wrote: >>> Fix snapshot reference leak if lo_export fails. >> This commit seems to lack the update in largeobject_1 as per hamerkop = in: >=20 > Fixed, thanks! >=20 > I'm a bit surprised none of the other Windows systems on the buildfarm = complained. The difference in largeobject_1 output is apparently that = the 'tenk.data' file uses Windows line endings. I guess that on all the = other Windows hosts, git has been configured to use Unix line endings. Interesting, so when hamerkop is offline (which it was for a month) we = don't have coverage for Windows line endings? That's worth keeping in mind. -- Daniel Gustafsson https://vmware.com/