Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.12\))
Subject: Re: pgsql: Revert online data checksum transitions
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CAJ7c6TOJnA7V7gQXa6WpdNUwtjzH+2Dd6yW8mtMO-KttPWp4+w@mail.gmail.com>
Date: Wed, 16 Sep 2026 14:43:15 +0200
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Masao Fujii <masao.fujii@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se>
References: 
 <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
 <1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se>
 <CAJ7c6TOJnA7V7gQXa6WpdNUwtjzH+2Dd6yW8mtMO-KttPWp4+w@mail.gmail.com>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482%40yesql.se>
Precedence: bulk

> On 16 Sep 2026, at 14:32, Aleksander Alekseev =
<aleksander@tigerdata.com> wrote:

>>> We should remove data_page_checksum_version from the =
pg_control_checkpoint
>>> entry in pg_proc.dat and reduce proargmodes from 20 output columns =
to 19?
>>=20
>> Ugh, I thought I had tested everything but clearly missed this one. =
Will fix immediately when back from lunch.
>=20
> I noticed that the revert was applied to REL_19_STABLE but not the
> master branch. Just wanted to make sure that's the plan.

That's indeed the plan.  The remaining issue that a user can, under the =
right
set of circumstances, get a false positive page verification in an =
orphaned
file failure during base backup.  The warning is harmless for data =
integrity,
but is non-trivial for the user to resolve since we don't provide any =
tools for
dealing with orphaned files.  Fixing this in master will reduce churn.

--
Daniel Gustafsson