MIME-Version: 1.0
References: <E1tzmW2-002COZ-2W@gemulon.postgresql.org>
 <CA+HiwqFT0fPPoYBr0iUFWNB-Og7bEXB9hB=6ogk_qD9=OM8Vbw@mail.gmail.com>
In-Reply-To: 
 <CA+HiwqFT0fPPoYBr0iUFWNB-Og7bEXB9hB=6ogk_qD9=OM8Vbw@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Fri, 27 Mar 2026 16:15:32 +0900
Message-ID: 
 <CA+HiwqG=_5tSA-FWJ_Fzs2xWkxOUxFhzDs2KaDCUDHQOKe41ew@mail.gmail.com>
Subject: Re: pgsql: Doc: add information about partition locking
To: David Rowley <drowley@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000005d827a064dfc458d"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BHiwqG%3D_5tSA-FWJ_Fzs2xWkxOUxFhzDs2KaDCUDHQOKe41ew%40mail.gmail.com>
Precedence: bulk

--0000000000005d827a064dfc458d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 27, 2026 at 4:09=E2=80=AFPM Amit Langote <amitlangote09@gmail.c=
om> wrote:
> Hi David,
>
> On Wed, Apr 2, 2025 at 10:03=E2=80=AFAM David Rowley <drowley@postgresql.=
org> wrote:
> >
> > Doc: add information about partition locking
> >
> > The documentation around locking of partitions for the executor startup
> > phase of run-time partition pruning wasn't clear about which partitions
> > were being locked.  Fix that.
> >
> > Reviewed-by: Tender Wang <tndrwang@gmail.com>
> > Discussion: https://postgr.es/m/CAApHDvp738G75HfkKcfXaf3a8s%3D6mmtOLh46=
tMD0D2hAo1UCzA%40mail.gmail.com
> > Backpatch-through: 13
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/121d774caea4c93c8b36fb20a17ef7=
74e60894d6
>
> -       <command>EXPLAIN</command> output.
> +       <command>EXPLAIN</command> output.  The query planner obtains loc=
ks for
> +       all partitions which are part of the plan.  However, when the exe=
cutor
> +       uses a cached plan, locks are only obtained on the partitions whi=
ch
> +       remain after partition pruning done during the initialization pha=
se of
> +       execution, i.e., the ones shown in the <command>EXPLAIN</command>
> +       output and not the ones referred to by the
> +       <quote>Subplans Removed</quote> property.
>        </para>
>       </listitem>
>
> This text was correct when committed, but became incorrect after I
> reverted 525392d57 in May 2025. Sorry for not catching it sooner.
>
> I think we should change the text in both master and REL_18_STABLE to
> match what you added in the older branches.  I can change it back to
> this when we get pruning-aware locking again.

Will apply the attached.

--=20
Thanks, Amit Langote

--0000000000005d827a064dfc458d
Content-Type: application/octet-stream;
	name="v1-0001-Doc-fix-stale-text-about-partition-locking-with-c.patch"
Content-Disposition: attachment;
	filename="v1-0001-Doc-fix-stale-text-about-partition-locking-with-c.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn8kgxct0>
X-Attachment-Id: f_mn8kgxct0

RnJvbSA2Y2NhMWUxYjdmMjk0NWRiNjM4NjNlMjM2Y2E2MmExZDYyOTFkNDkzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWl0IExhbmdvdGUgPGFtaXRsYW5AcG9zdGdyZXNxbC5vcmc+
CkRhdGU6IEZyaSwgMjcgTWFyIDIwMjYgMTY6MTI6MjMgKzA5MDAKU3ViamVjdDogW1BBVENIIHYx
XSBEb2M6IGZpeCBzdGFsZSB0ZXh0IGFib3V0IHBhcnRpdGlvbiBsb2NraW5nIHdpdGggY2FjaGVk
CiBwbGFucwoKQ29tbWl0IDEyMWQ3NzRjYWVhIGFkZGVkIHRleHQgdG8gbWFzdGVyIGRlc2NyaWJp
bmcgcHJ1bmluZy1hd2FyZQpsb2NraW5nIGJlaGF2aW9yIGludHJvZHVjZWQgYnkgNTI1MzkyZDU3
LiAgVGhhdCBiZWhhdmlvciB3YXMKcmV2ZXJ0ZWQgaW4gTWF5IDIwMjUsIG1ha2luZyB0aGUgdGV4
dCBpbmNvcnJlY3QuICBSZXBsYWNlIGl0IHdpdGgKdGhlIHRleHQgdXNlZCBpbiBiYWNrIGJyYW5j
aGVzLCB3aGljaCBjb3JyZWN0bHkgZGVzY3JpYmVzIGN1cnJlbnQKYmVoYXZpb3I6IHBydW5lZCBw
YXJ0aXRpb25zIGFyZSBzdGlsbCBsb2NrZWQgYXQgdGhlIGJlZ2lubmluZyBvZgpleGVjdXRpb24u
CgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL0NBK0hpd3FGVDBmUFBvWUJyMGlVRldO
Qi1PZzdiRVhCOWhCPTZvZ2tfcUQ5PU9NOFZid0BtYWlsLmdtYWlsLmNvbQotLS0KIGRvYy9zcmMv
c2dtbC9kZGwuc2dtbCB8IDEwICsrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv
bnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2RkbC5zZ21s
IGIvZG9jL3NyYy9zZ21sL2RkbC5zZ21sCmluZGV4IDg0MjFlY2FjZTFiLi5iZDhjYjQ2MWNiYSAx
MDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL2RkbC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9kZGwu
c2dtbApAQCAtNTQxNiwxMyArNTQxNiw5IEBAIEVYUExBSU4gU0VMRUNUIGNvdW50KCopIEZST00g
bWVhc3VyZW1lbnQgV0hFUkUgbG9nZGF0ZSAmZ3Q7PSBEQVRFICcyMDA4LTAxLTAxJzsKICAgICAg
ICBJdCBpcyBwb3NzaWJsZSB0byBkZXRlcm1pbmUgdGhlIG51bWJlciBvZiBwYXJ0aXRpb25zIHdo
aWNoIHdlcmUKICAgICAgICByZW1vdmVkIGR1cmluZyB0aGlzIHBoYXNlIGJ5IG9ic2VydmluZyB0
aGUKICAgICAgICA8cXVvdGU+U3VicGxhbnMgUmVtb3ZlZDwvcXVvdGU+IHByb3BlcnR5IGluIHRo
ZQotICAgICAgIDxjb21tYW5kPkVYUExBSU48L2NvbW1hbmQ+IG91dHB1dC4gIFRoZSBxdWVyeSBw
bGFubmVyIG9idGFpbnMgbG9ja3MgZm9yCi0gICAgICAgYWxsIHBhcnRpdGlvbnMgd2hpY2ggYXJl
IHBhcnQgb2YgdGhlIHBsYW4uICBIb3dldmVyLCB3aGVuIHRoZSBleGVjdXRvcgotICAgICAgIHVz
ZXMgYSBjYWNoZWQgcGxhbiwgbG9ja3MgYXJlIG9ubHkgb2J0YWluZWQgb24gdGhlIHBhcnRpdGlv
bnMgd2hpY2gKLSAgICAgICByZW1haW4gYWZ0ZXIgcGFydGl0aW9uIHBydW5pbmcgZG9uZSBkdXJp
bmcgdGhlIGluaXRpYWxpemF0aW9uIHBoYXNlIG9mCi0gICAgICAgZXhlY3V0aW9uLCBpLmUuLCB0
aGUgb25lcyBzaG93biBpbiB0aGUgPGNvbW1hbmQ+RVhQTEFJTjwvY29tbWFuZD4KLSAgICAgICBv
dXRwdXQgYW5kIG5vdCB0aGUgb25lcyByZWZlcnJlZCB0byBieSB0aGUKLSAgICAgICA8cXVvdGU+
U3VicGxhbnMgUmVtb3ZlZDwvcXVvdGU+IHByb3BlcnR5LgorICAgICAgIDxjb21tYW5kPkVYUExB
SU48L2NvbW1hbmQ+IG91dHB1dC4gIEl0J3MgaW1wb3J0YW50IHRvIG5vdGUgdGhhdCBhbnkKKyAg
ICAgICBwYXJ0aXRpb25zIHJlbW92ZWQgYnkgdGhlIHBhcnRpdGlvbiBwcnVuaW5nIGRvbmUgYXQg
dGhpcyBzdGFnZSBhcmUKKyAgICAgICBzdGlsbCBsb2NrZWQgYXQgdGhlIGJlZ2lubmluZyBvZiBl
eGVjdXRpb24uCiAgICAgICA8L3BhcmE+CiAgICAgIDwvbGlzdGl0ZW0+CiAKLS0gCjIuNDcuMwoK
--0000000000005d827a064dfc458d--