public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Langote <[email protected]>
To: David Rowley <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Doc: add information about partition locking
Date: Mon, 30 Mar 2026 10:32:57 +0900
Message-ID: <CA+HiwqGtMJWAs398ahifM0LXAVrwxcx6UYSjeo-a9Pm0Lxh6Fg@mail.gmail.com> (raw)
In-Reply-To: <CA+HiwqG=_5tSA-FWJ_Fzs2xWkxOUxFhzDs2KaDCUDHQOKe41ew@mail.gmail.com>
References: <[email protected]>
	<CA+HiwqFT0fPPoYBr0iUFWNB-Og7bEXB9hB=6ogk_qD9=OM8Vbw@mail.gmail.com>
	<CA+HiwqG=_5tSA-FWJ_Fzs2xWkxOUxFhzDs2KaDCUDHQOKe41ew@mail.gmail.com>

On Fri, Mar 27, 2026 at 4:15 PM Amit Langote <[email protected]> wrote:
> On Fri, Mar 27, 2026 at 4:09 PM Amit Langote <[email protected]> wrote:
> > Hi David,
> >
> > On Wed, Apr 2, 2025 at 10:03 AM David Rowley <[email protected]> wrote:
> > >
> > > Doc: add information about partition locking
> > >
> > > The documentation around locking of partitions for the executor startup
> > > phase of run-time partition pruning wasn't clear about which partitions
> > > were being locked.  Fix that.
> > >
> > > Reviewed-by: Tender Wang <[email protected]>
> > > Discussion: https://postgr.es/m/CAApHDvp738G75HfkKcfXaf3a8s%3D6mmtOLh46tMD0D2hAo1UCzA%40mail.gmail.com
> > > Backpatch-through: 13
> > >
> > > Branch
> > > ------
> > > master
> > >
> > > Details
> > > -------
> > > https://git.postgresql.org/pg/commitdiff/121d774caea4c93c8b36fb20a17ef774e60894d6
> >
> > -       <command>EXPLAIN</command> output.
> > +       <command>EXPLAIN</command> output.  The query planner obtains locks for
> > +       all partitions which are part of the plan.  However, when the executor
> > +       uses a cached plan, locks are only obtained on the partitions which
> > +       remain after partition pruning done during the initialization phase of
> > +       execution, i.e., the ones shown in the <command>EXPLAIN</command>
> > +       output and not the ones referred to by the
> > +       <quote>Subplans Removed</quote> property.
> >        </para>
> >       </listitem>
> >
> > This text was correct when committed, but became incorrect after I
> > reverted 525392d57 in May 2025. Sorry for not catching it sooner.
> >
> > I think we should change the text in both master and REL_18_STABLE to
> > match what you added in the older branches.  I can change it back to
> > this when we get pruning-aware locking again.
>
> Will apply the attached.

Pushed.

-- 
Thanks, Amit Langote

view thread (9+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Doc: add information about partition locking
  In-Reply-To: <CA+HiwqGtMJWAs398ahifM0LXAVrwxcx6UYSjeo-a9Pm0Lxh6Fg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox