MIME-Version: 1.0
References: <E1tlXde-000VTE-1s@gemulon.postgresql.org>
In-Reply-To: <E1tlXde-000VTE-1s@gemulon.postgresql.org>
From: Robert Haas <robertmhaas@gmail.com>
Date: Mon, 17 Mar 2025 13:20:22 -0400
Message-ID: 
 <CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com>
Subject: Re: pgsql: pg_upgrade: Preserve default char signedness value from
 old clus
To: Masahiko Sawada <msawada@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BTgmoYg5e4oznn0XGoJ3%2BmceG1qe_JJt34rF2JLwvGS5T1hgQ%40mail.gmail.com>
Precedence: bulk

On Fri, Feb 21, 2025 at 1:20=E2=80=AFPM Masahiko Sawada <msawada@postgresql=
.org> wrote:
> pg_upgrade: Preserve default char signedness value from old cluster.

Hi,

I noticed that after running 'meson test --suite setup --suite
pg_upgrade', the file delete_old_cluster.sh is left behind in the
source directory, which should not happen. Everything created for the
tests should be created in the meson directories. I traced the problem
down to 005_char_signedness.pl. I believe the problem is likely that
other pg_upgrade TAP tests include this locution, whereas
005_char_signedness.pl does not:

# In a VPATH build, we'll be started in the source directory, but we want
# to run pg_upgrade in the build directory so that any files generated fini=
sh
# in it, like delete_old_cluster.{sh,bat}.
chdir ${PostgreSQL::Test::Utils::tmp_check};

Regards,

--=20
Robert Haas
EDB: http://www.enterprisedb.com