public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pgsql: Avoid invalidating all RelationSyncCache entries on publication
Date: Mon, 17 Mar 2025 12:05:22 -0400
Message-ID: <CA+Tgmoa+GkGNZ86QmqyuOCHWaBkOEJAEPfghEQ1d8_+KudVknw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Thu, Mar 13, 2025 at 12:00 AM Amit Kapila <[email protected]> wrote:
> Avoid invalidating all RelationSyncCache entries on publication rename.
>
> On Publication rename, we need to only invalidate the RelationSyncCache
> entries corresponding to relations that are part of the publication being
> renamed.
>
> As part of this patch, we introduce a new invalidation message to
> invalidate the cache maintained by the logical decoding output plugin. We
> can't use existing relcache invalidation for this purpose, as that would
> unnecessarily cause relcache invalidations in other backends.

This seems like too much infrastructure for a niche optimization. If
there are plans to use this new invalidation message type to optimize
a bunch of other cases, then maybe it's worth it, but adding this just
to cover the presumably-rare case of ALTER PUBLICATION .. RENAME
doesn't seem worth it to me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Avoid invalidating all RelationSyncCache entries on publication
  In-Reply-To: <CA+Tgmoa+GkGNZ86QmqyuOCHWaBkOEJAEPfghEQ1d8_+KudVknw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox