Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuW3m-009PEK-Q9 for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 12:28:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tuW3l-00Dbk5-Fe for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 12:28:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuW3l-00Dbjx-56 for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 12:28:41 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tuW3h-003Yn6-0t for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 12:28:40 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-ac2ab99e16eso176298766b.0 for ; Tue, 18 Mar 2025 05:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742300917; x=1742905717; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PQUiNmTnDI2iUxfleaoAbWLzr0PlIFsA+Iuu7IITmN0=; b=PvDMulooUTl8qBwmiDBRFdDKQAr5Rdhd4DRYYduCPsf/FAj5mlp5Csi9GPevSy6Fsi NrzZod+uTUgCIxt8kIDHUMKgORL7yiaxJQfslKN/KxKXPxbSL70RIqJaOcX2QARnnJXB uHGutlzCnyv+SNkHzvdwn0AD2uzam1vlcMNCfXPrXWxN1s/5t/wXRnycc8J6G6AE5lY2 gLJY82B+SaMORINmOfSKFkos8FHPQWyiPRuBNLjEFVpXCzSIiEtANN4UezYdos3DF0vp k52pXy8SIyAqvFJdF0F+B0rWBJzkYk1WmK/shQi7r+WelzUT+Adl/2mCF4XOt8EyFhZe Nvwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742300917; x=1742905717; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PQUiNmTnDI2iUxfleaoAbWLzr0PlIFsA+Iuu7IITmN0=; b=FGjdvhG7D6H7Yp1l4BJYtRKb3jKljcCBik2ASC03Q6ZcqKMalBzH07hy0I4YGMwMSs PC2SjYd0EO6NrzELd+1UPO1Z0CopeLNBh9qrcD2BD5moHvz3UvZYued4Ahz+skCTXEi0 lbnrsIgm0KvpQguSKx/04QclW/NNxpndaLM4HQtV8GPiQiVh+8wDOyGniZ/MNJyp8a4i SqvIer9m8/I87BG4DKAc1bwDjefgRGX3ehL0irYWDIxoS8dIXPGod0ceQsoseqTXeIpT Q60QP/o/SEQkP9kgecMELuwnjFPwkbTFTWxCqLYmEcBSGJj5rQWRp9pF7FPXWWVxOGMX meRg== X-Forwarded-Encrypted: i=1; AJvYcCUrElF3N1h7EJUhrK77LN1GdUlMfE8gkHIuqXEZE8gU6jlB9fIPWnoK6hdl0F65vi0HPCemGaerAl02sNO4@lists.postgresql.org X-Gm-Message-State: AOJu0Yy40VafHnJ51IeQAGycThPHl6DhuINIbh+bRpHXouzSF5W8+Elb IXcFgJnBhgfAZQ8ueBpYWgKiINO14eMzMj/5UQOn0h6LzSvtm5wm5ZXRowtUKAK6nNEXv5WbTjx uMSZKJr1LcA3BxPhJz6+rgz6BmwRQpp2X X-Gm-Gg: ASbGncu3MChECgHgRIWAxQwil/EdnRuw0zgDcnd5IETTUaaFp1+R/lkdMG5LyHi8gxR OJ6HVoyUC5dmCXmXZHu1NR99lhS+KM0RoZ9Orxq7dF750QXW7tapd5ZY+OSO8CSxa5Opq7scLEz Ox1dSwBPZJqGhnfDrmbxrk2SU1sQ== X-Google-Smtp-Source: AGHT+IH5BPQPecg58nfLGPHA0Sy916mWZzW8vSMalrU7bU7kCt6x8z2fHZyDXlNbUH6nnGEFYTIN0E8uL7LeK80bj3E= X-Received: by 2002:a17:907:2ce1:b0:ac2:ede5:d0d3 with SMTP id a640c23a62f3a-ac3302f37damr1785683966b.27.1742300916674; Tue, 18 Mar 2025 05:28:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robert Haas Date: Tue, 18 Mar 2025 08:28:25 -0400 X-Gm-Features: AQ5f1JokI6CbtKx8JHhyA68xaP_ME4RgJ4xsfM6k7xhb2p3HiJWPOpd09W-O_wY Message-ID: Subject: Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus To: Masahiko Sawada Cc: Masahiko Sawada , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 18, 2025 at 12:36=E2=80=AFAM Masahiko Sawada wrote: > > Cool. The commit message refers to 003_char_signedness, but the test > > name is 005, not 003. > > Thank you for reviewing the patch. I've pushed the patch after fixing it. Thanks for taking care of it (and so quickly!). --=20 Robert Haas EDB: http://www.enterprisedb.com