Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuNDr-007rGA-HO for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 03:02:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tuNDp-006DHa-SC for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 03:02:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuNDp-006DHS-CB for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 03:02:29 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tuNDm-003QkJ-36 for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 03:02:28 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-ac2902f7c2aso80103366b.1 for ; Mon, 17 Mar 2025 20:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742266945; x=1742871745; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h4+0k20n03H5EhVNVjEscE/tPidaMNNWqGZNE/vFE94=; b=DNGl0caQ7mxKN/3UlImzYK7S+iApE31PzhEg50ZoRRi38JPoY8JMVjUlHc5/Shm5A/ PLYSWBm95du/p7ptxT2Fj0aiQLcIpt8SP89RNpDNmqmLZr1abixEemRkBBwKNrbpvwAc K+TW92h5W2S/iuD43D77ljbvF9FPPLAVwd1q8cpnboCvlVdjnM2HkYpkHuw3nM0Gu0bZ PVObVcMlO4ePgeDbERish11ET7c+K9sZc/XUr3LluLp6PorGH5DslMvYDui1TLeeylcD yaLMyysR7msw8642e6B4hHXCFX3RDVD9CZQPlI4EHDCJoW8ugNsL2Bq4SwJ6bCu1sDfv dfYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742266945; x=1742871745; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4+0k20n03H5EhVNVjEscE/tPidaMNNWqGZNE/vFE94=; b=qZ6tNloS3TinWB2vHqHqny/IVD4hm31p9rujadOsimEQ0KhgN1okXv6G9McXYVqcpx LZ0tjrM+c65bE1lWBQze+92cKSo7cX0UCdGYZcsgwaKKt0d2mYQcDz1gcYp8v8NEBZ3L 8XJpI3AeuWv+RvYNAkvWsyPAe3ZktnfKiAWl4+PjA2eEiqtK3i++OzIRxzBttMnVOT4m Pqk3d4Rlw38pQiY2kG/ngS7XpQygbYjzENJ60xZImgwZNwVu8Ki4twbr1zRXByQ7lirq +nRmv7V9HAT9+Zto8e1P2tLYAy9A6hEHjgTOExHFoOjmunpwNMTBP7op1O/y8N00l98N Qxrg== X-Forwarded-Encrypted: i=1; AJvYcCVxj/fJglQO3saM5NJlFfGx1GiN7x6OrIgQohOaEqWmPIGrLZILA/k27g2WhJBVBfUl9j8br9ixe9eABG7u@lists.postgresql.org X-Gm-Message-State: AOJu0YytOBjCuhb0gRK0Aa63W8VHq04MisT/ZvFla3GuhogbYB6+06Kd CXPDb7QKUsVGCyxMalMSJsYBmkaSov6y23cixy1ktHneDywE6W2JD2zyYbFTABsWO8Z10xEmdGi m3tZtVb6zh83C/ZPKcL6flp3VTSU= X-Gm-Gg: ASbGncuZnkyIgkW8GwG0HCHfg16C+f/jrbY9vdJkdsA8XglEqdRuiuJrM8VUSpV4JpT nVmMA9/vAFmNG9nZsJRrOH9vblY7J6Jcqc1wu4HGvnidf+pg1hA0dXnFrmQJEIhZt0SKc6aDtm/ Obqa9xEr6j9YNCYO14NNZfk+8+ow== X-Google-Smtp-Source: AGHT+IGEWwOGCq8Q4jx4IP/oRG2jhtDUqmclm5qk2q9D89hDC0tCRHQ/3aYEbi3NhjqV89fPHYjdU6Z2MwWKtanJBq4= X-Received: by 2002:a17:907:7241:b0:abf:78ff:e271 with SMTP id a640c23a62f3a-ac3304dffa0mr1681773366b.49.1742266945248; Mon, 17 Mar 2025 20:02:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robert Haas Date: Mon, 17 Mar 2025 23:02:14 -0400 X-Gm-Features: AQ5f1JqAyvf2vnbROOIjlC9dSkAMxBKlHLazGbEffO19Pws2EE_t6aYZEGn4l3o Message-ID: Subject: Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus To: Masahiko Sawada Cc: Masahiko Sawada , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Mar 17, 2025 at 6:02=E2=80=AFPM Masahiko Sawada wrote: > I've confirmed the issue and attached a patch to fix it. Cool. The commit message refers to 003_char_signedness, but the test name is 005, not 003. --=20 Robert Haas EDB: http://www.enterprisedb.com