MIME-Version: 1.0
References: 
 <CA+hUKGLqengPszjoQeD_7nmHsjGZS380+ymke-Fm=nNGMEQuhw@mail.gmail.com>
 <202202142122.eqz4mu2ecfes@alvherre.pgsql>
 <CA+hUKG+LX+mjBTPV=u4RnZU_5sp=BgCHh_91a1f1NFoKphtJWQ@mail.gmail.com>
 <3155481.1644950069@sss.pgh.pa.us>
 <CA+hUKG+p=faBQR2PSAqWoWa+_tJdKPT0wjZPQe7XcDEttUCgdQ@mail.gmail.com>
 <20220215224123.fx2mxkvlbvhk7377@alap3.anarazel.de>
 <3224284.1644965080@sss.pgh.pa.us>
 <CA+hUKGKM6BWHy9oi9Oyt7wgVLgi3ht2hb=k0Tmf0RLDhkEEXkQ@mail.gmail.com>
 <1407185.1766682319@sss.pgh.pa.us>
In-Reply-To: <1407185.1766682319@sss.pgh.pa.us>
From: Thomas Munro <thomas.munro@gmail.com>
Date: Mon, 29 Dec 2025 22:15:57 +1300
Message-ID: 
 <CA+hUKGJwFNH2yTLeWPaUy9Le=AgvEripEAdmyem7naKGGCAFEQ@mail.gmail.com>
Subject: Re: pgsql: Track LLVM 15 changes.
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Fabien COELHO <coelho@cri.ensmp.fr>, Thomas Munro <tmunro@postgresql.org>,
	pgsql-committers <pgsql-committers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000174681064713b36e"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BhUKGJwFNH2yTLeWPaUy9Le%3DAgvEripEAdmyem7naKGGCAFEQ%40mail.gmail.com>
Precedence: bulk

--000000000000174681064713b36e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 26, 2025 at 6:05=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
> > Shortly I'll do the back-patch of LLVM 14 API changes (their final
> > release tag is scheduled for tomorrow, as I've been reminded by
> > package maintainers trying and failing to build).  But I figured I
> > should also follow up on this bandaid solution to the API deprecation
> > warnings, that is, silencing them for now, so we don't spew screeds of
> > warnings.  Does someone have a better idea than the attached?
>
> The bit added by commit a56e7b660 is still there in
> src/backend/jit/llvm/Makefile:
>
> +# LLVM 14 produces deprecation warnings.  We'll need to make some change=
s
> +# before the relevant functions are removed, but for now silence the war=
nings.
> +ifeq ($(GCC), yes)
> +LLVM_CFLAGS +=3D -Wno-deprecated-declarations
> +endif
>
> Surely we don't need this anymore?  I tried removing it locally
> and didn't see any such warnings (with Red Hat's llvm 20.1.8).

Yeah.  We should just delete these obsolete lines in 18 and master.
For older branches, I think it should be enough to update the comment
in 14-17, as attached.  We could work harder and suppress the warnings
only for LLVM 14 and 15 specifically in PostgreSQL 14-17, but it seems
like the main point is surely to have *something* watching out for new
warnings that are added in future LLVM versions, and we'll get that
from the newer branches.

--000000000000174681064713b36e
Content-Type: application/octet-stream;
	name="0001-jit-Remove-suppression-of-deprecation-warnings.patch"
Content-Disposition: attachment;
	filename="0001-jit-Remove-suppression-of-deprecation-warnings.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mjqxofgs0>
X-Attachment-Id: f_mjqxofgs0

RnJvbSA3YjYwZjhmMzg1ZWNkZGE4MGE4MmQ2YTk5ZGYwZGI0ZGUyYjY4OWEzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgTXVucm8gPHRob21hcy5tdW5yb0BnbWFpbC5jb20+
CkRhdGU6IE1vbiwgMjkgRGVjIDIwMjUgMTg6MTM6NTcgKzEzMDAKU3ViamVjdDogW1BBVENIXSBq
aXQ6IFJlbW92ZSBzdXBwcmVzc2lvbiBvZiBkZXByZWNhdGlvbiB3YXJuaW5ncy4KClJFTF8xOF9T
VEFCTEUgYW5kIG1hc3RlciBoYXZlIGNvbW1pdCBlZTQ4NTkxMiwgc28gdGhleSBhbHdheXMgdXNl
IHRoZQpuZXcgb3BhcXVlIHBvaW50ZXIgQVBJLiAgUmV2ZXJ0IGNvbW1pdCBhNTZlN2I2NjAgaW4g
dGhvc2UgYnJhbmNoZXMsIHNvCnRoYXQgd2UgbG9vayBvdXQgZm9yIGFueSBuZXcgZGVwcmVjYXRp
b24gd2FybmluZ3MgdGhhdCBhcnJpdmUgaW4gZnV0dXJlCkxMVk0gdmVyc2lvbnMuCgpPbGRlciBi
cmFuY2hlcyBjb250aW51ZWQgdG8gdXNlIGZ1bmN0aW9ucyBtYXJrZWQgZGVwcmVjYXRlZCBpbiBM
TFZNIDE0CmFuZCAxNSAoYnV0IG5vdCBMTFZNIDE2KyksIGFzIGEgcHJlY2F1dGlvbiBhZ2FpbnN0
IHVuZm9yZXNlZW4KY29tcGF0aWJpbGl0eSBwcm9ibGVtcyB3aXRoIGJpdGNvZGUgYWxyZWFkeSBz
aGlwcGVkLiAgSW4gdGhvc2UgYnJhbmNoZXMsCnRoZSBjb21tZW50IGV4cGxhaW5pbmcgdGhlIHdh
cm5pbmcgc3VwcHJlc3Npb24gaXMgdXBkYXRlZCB0byBleHBsYWluCnRoYXQuICBJbiB0aGVvcnkg
dGhvc2UgYnJhbmNoZXMgY291bGQgYXBwbHkgdGhlIHdhcm5pbmcgc3VwcHJlc3Npb24gb25seQpm
b3IgTExWTSAxNCBhbmQgMTUgc3BlY2lmaWNhbGx5LCBidXQgdGhhdCBpc24ndCBkb25lIGhlcmUu
CgpCYWNrcGF0Y2gtdGhyb3VnaDogMTQKUmVwb3J0ZWQtYnk6IFRvbSBMYW5lIDx0Z2xAc3NzLnBn
aC5wYS51cz4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS8xNDA3MTg1LjE3NjY2ODIz
MTklNDBzc3MucGdoLnBhLnVzCi0tLQogc3JjL2JhY2tlbmQvaml0L2xsdm0vTWFrZWZpbGUgfCA2
ICsrKystLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9qaXQvbGx2bS9NYWtlZmlsZSBiL3NyYy9iYWNrZW5k
L2ppdC9sbHZtL01ha2VmaWxlCmluZGV4IDY4Njc3YmE0MmUxLi4xYWY5NTU4MmVhMyAxMDA2NDQK
LS0tIGEvc3JjL2JhY2tlbmQvaml0L2xsdm0vTWFrZWZpbGUKKysrIGIvc3JjL2JhY2tlbmQvaml0
L2xsdm0vTWFrZWZpbGUKQEAgLTIyLDggKzIyLDEwIEBAIGVuZGlmCiBQR0ZJTEVERVNDID0gImxs
dm1qaXQgLSBKSVQgdXNpbmcgTExWTSIKIE5BTUUgPSBsbHZtaml0CiAKLSMgTExWTSAxNCBwcm9k
dWNlcyBkZXByZWNhdGlvbiB3YXJuaW5ncy4gIFdlJ2xsIG5lZWQgdG8gbWFrZSBzb21lIGNoYW5n
ZXMKLSMgYmVmb3JlIHRoZSByZWxldmFudCBmdW5jdGlvbnMgYXJlIHJlbW92ZWQsIGJ1dCBmb3Ig
bm93IHNpbGVuY2UgdGhlIHdhcm5pbmdzLgorIyBTb21lIGZ1bmN0aW9ucyBjYWxsZWQgaW4gTExW
TSAxNCBhbmQgTExWTSAxNSBhcmUgbWFya2VkIHdpdGggR0NDIGRlcHJlY2F0aW9uCisjIGF0dHJp
YnV0ZXMuICBGb3IgTExWTSAxNiBhbmQgbGF0ZXIsIHdlIHVzZSB0aGUgbmV3ZXIgcmVwbGFjZW1l
bnQgZnVuY3Rpb25zCisjIGluc3RlYWQsIGJ1dCB3YXJuaW5ncyBhcmUgc3VwcHJlc3NlZCB1bmNv
bmRpdGlvbmFsbHkuICAoTm90ZSB0aGF0IHRoaXMgaXMKKyMgb25seSBkb25lIGluIGJyYW5jaGVz
IGJlZm9yZSBSRUxfMThfU1RBQkxFLikKIGlmZXEgKCQoR0NDKSwgeWVzKQogTExWTV9DRkxBR1Mg
Kz0gLVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucwogZW5kaWYKLS0gCjIuNTIuMAoK
--000000000000174681064713b36e--