public inbox for [email protected]
help / color / mirror / Atom feedFrom: Thomas Munro <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Fabien COELHO <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: pgsql-committers <[email protected]>
Subject: Re: pgsql: Track LLVM 15 changes.
Date: Tue, 15 Mar 2022 12:12:44 +1300
Message-ID: <CA+hUKGKM6BWHy9oi9Oyt7wgVLgi3ht2hb=k0Tmf0RLDhkEEXkQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CA+hUKGLqengPszjoQeD_7nmHsjGZS380+ymke-Fm=nNGMEQuhw@mail.gmail.com>
<[email protected]>
<CA+hUKG+LX+mjBTPV=u4RnZU_5sp=BgCHh_91a1f1NFoKphtJWQ@mail.gmail.com>
<[email protected]>
<CA+hUKG+p=faBQR2PSAqWoWa+_tJdKPT0wjZPQe7XcDEttUCgdQ@mail.gmail.com>
<[email protected]>
<[email protected]>
On Wed, Feb 16, 2022 at 11:44 AM Tom Lane <[email protected]> wrote:
> Andres Freund <[email protected]> writes:
> > On 2022-02-16 09:18:53 +1300, Thomas Munro wrote:
> >> Yeah I mentioned this problem in the other thread. I got as far as
> >> finding this write-up:
> >> https://llvm.org/docs/OpaquePointers.html
>
> > Given that major parts of llvm (clang alone contains ~1k references) aren't
> > yet transitioned, I wonder if should silence them for now?
>
> For my own part, I don't have any problem with just filtering these
> warnings for now. I don't need any buildfarm changes for that.
Shortly I'll do the back-patch of LLVM 14 API changes (their final
release tag is scheduled for tomorrow, as I've been reminded by
package maintainers trying and failing to build). But I figured I
should also follow up on this bandaid solution to the API deprecation
warnings, that is, silencing them for now, so we don't spew screeds of
warnings. Does someone have a better idea than the attached?
Attachments:
[text/x-patch] 0001-Silence-LLVM-14-API-deprecation-warnings.patch (1.1K, 2-0001-Silence-LLVM-14-API-deprecation-warnings.patch)
download | inline diff:
From 91d1f833cbf6f19b5ebb4ec59a44d122725a5963 Mon Sep 17 00:00:00 2001
From: Thomas Munro <[email protected]>
Date: Tue, 15 Mar 2022 12:01:49 +1300
Subject: [PATCH] Silence LLVM 14 API deprecation warnings.
We are going to need to handle the opaque pointer API changes[1],
possibly in time for LLVM 15, but in the meantime let's silence the
warnings produced by LLVM 14.
[1] https://llvm.org/docs/OpaquePointers.html
Discussion: https://postgr.es/m/CA%2BhUKG%2Bp%3DfaBQR2PSAqWoWa%2B_tJdKPT0wjZPQe7XcDEttUCgdQ%40mail.gmail.com
---
src/backend/jit/llvm/Makefile | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/backend/jit/llvm/Makefile b/src/backend/jit/llvm/Makefile
index 0268bd46d5..4af57b02b0 100644
--- a/src/backend/jit/llvm/Makefile
+++ b/src/backend/jit/llvm/Makefile
@@ -22,6 +22,12 @@ endif
PGFILEDESC = "llvmjit - JIT using LLVM"
NAME = llvmjit
+# LLVM 14 produces deprecation warnings. We'll handle those, but for now
+# silence the warnings.
+ifeq ($(GCC), yes)
+LLVM_CFLAGS += -Wno-deprecated-declarations
+endif
+
# All files in this directory use LLVM.
CFLAGS += $(LLVM_CFLAGS)
CXXFLAGS += $(LLVM_CXXFLAGS)
--
2.30.2
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgsql: Track LLVM 15 changes.
In-Reply-To: <CA+hUKGKM6BWHy9oi9Oyt7wgVLgi3ht2hb=k0Tmf0RLDhkEEXkQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox