Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1txAXD-0042Fs-As for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Mar 2025 20:06:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1txAXB-0090w4-9u for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Mar 2025 20:06:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <9erthalion6@gmail.com>) id 1txAXA-0090vI-S4 for pgsql-hackers@lists.postgresql.org; Tue, 25 Mar 2025 20:06:01 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from <9erthalion6@gmail.com>) id 1txAX9-0016UQ-0O for pgsql-hackers@lists.postgresql.org; Tue, 25 Mar 2025 20:05:59 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3996af42857so136133f8f.0 for ; Tue, 25 Mar 2025 13:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742933157; x=1743537957; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VZypP0NQu4MB4Vz63qznxBdnpMq9LMwFKZgKdyfj7y0=; b=lYitkjyL+IiB1gzazJjUHamA2RVht4pDb7eizwW2TLxlvlLeKe271QTrkA1OgNE1Tt VPt2H7plB+l3unZuvqyquy+DQqwq3e+62PnAnjG9FghVJF8q58KTbW6zuvkvg5K5ZJCO TFYg+GKkGReNzBM8x0HXXwn0CAjX5ww+omHam1h3ismYW+DoDut24rb/gNUXWJDEce/I wsSr6UCJ2fbZfiSdYI453ONt9FTeJmFdiLeOyMvRsAgcBrKiV8xYJKpfqrAYnZdn4R2L f4pn2AFtIsMim08SdIYjzKSqB178nZ9OMzelF+rj1eHmmYeFYRLh2uB8dyjpGiZZoEOb 5fWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742933157; x=1743537957; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VZypP0NQu4MB4Vz63qznxBdnpMq9LMwFKZgKdyfj7y0=; b=tltgBcY+VFnIH0AsC4syub3VYxxvNTlLutku3+cpjWJ8k6xZMb1yoNMllrpTrtAhhk jAk0SlXrKuiA1Vzol1/qYc1NArbZrs4sB9YPvshjxRcvMfLj6YxRjFbuJEsRo2wfdV0V IY4WYjW8JKfNId7lxqNNW77NSJsgNzBg3rfxaosLXvISlHzHYRw/pul2MVyifzYk+0gx JMUoNaFPJxxcdgk8U9AeIkyLjKWqGw2IsOkMO2padqNye6IxcyqrVhpNsTzWnyh2jSgU SrXvgtbfCd+RZX0nD1NsN+r0P1J9RePO/SrzYn0d+n/yU2HSDkyvqKk+ubWFfIbjxmER Nafg== X-Forwarded-Encrypted: i=1; AJvYcCVbsdxH8e0Jthi9CTQPaIHAtyjExVE4L8XAjqHUeentpCBcS0I8fyynwcJMwcNrlY/RD9y6B9rpPvn5H0lu@lists.postgresql.org X-Gm-Message-State: AOJu0YzIyNJb3z0jiPmmUDpKRZ7xRYh4mBgd8ZYVYdv6o95JN6zhh/tG 9HlmSaeNtmaGWsepU1cOZXLzAWQUo1cOeRLinGrmej4LMPGYHEgszRQusZxuaug1us1VGnEPtQq b/DYxs77SObixDsh0ok8vZfRbiIw= X-Gm-Gg: ASbGncugLtiv/cfjMqvaXslvS3Stl3kZYy9amB0Xd8E5Dig81GGt5kft3KTf/C+5FUr FL0EvJ8d0zww8kgUtcfCAKR8bvqtRUfwrYoDURb5KMVhS3epaQp8g3j956MslINGQB5s7fpGgJr 8VvIgdRjKxRNpjUEX1YY5G2YW8GA== X-Google-Smtp-Source: AGHT+IHRyQ66yEgZwp9lXJodKdhdx3zqvSivhwTGYV/4M7SVB8Oq7WcIFygQMFPRS5JTEKY87eHxzqqU8GoS9FC8LHU= X-Received: by 2002:a05:6000:1a88:b0:39a:c86d:e094 with SMTP id ffacd0b85a97d-39acc46dd0bmr993169f8f.17.1742933157168; Tue, 25 Mar 2025 13:05:57 -0700 (PDT) MIME-Version: 1.0 References: <1282250.1742921593@sss.pgh.pa.us> <202503251727.pn3eg43zqkdk@alvherre.pgsql> In-Reply-To: From: Dmitry Dolgov <9erthalion6@gmail.com> Date: Tue, 25 Mar 2025 21:05:44 +0100 X-Gm-Features: AQ5f1JoeSEQG8-0D7B1LKBzteT428swZGk0O-Jq4UDh6D0SMKX6fj72vUMZSxsA Message-ID: Subject: Re: Squash constant lists in query jumbling by default To: =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: Tom Lane , Christoph Berg , PostgreSQL Developers , Sami Imseih , Michael Paquier , Julien Rouhaud Content-Type: multipart/alternative; boundary="000000000000b351520631303f5f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000b351520631303f5f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 25, 2025, 7:40 PM Dmitry Dolgov <9erthalion6@gmail.com> wrote: > >>> On Tue, Mar 25, 2025, 6:28 PM =C3=81lvaro Herrera > wrote: > > On 2025-Mar-25, Tom Lane wrote: > > > If this GUC sticks around, it should be at least PGC_SUSET (on > > > the analogy of compute_query_id) to make it harder to break > > > pg_stat_statements that way. > > > I have no problem making it superuser-only, and I can see making "on" be > > the default. I am not opposed to removing it completely either, if we > > really think that the current behavior is no longer useful for anybody. > > > I'm in favor of removing the GUC of course, but if memory serves there > were some folks in the patch discussion thread, who claimed they would > need to be able to keep non-squashed behavior. I don't recall if there we= re > particular arguments to support that, will try to find those messages > again. > Nevermind, I've checked it out -- I think the case I had in mind [1] in fac= t supports GUC removal: > If anyone subtly changes jumbling logic when the extension is active, the instance could get huge performance issues. [1]: https://www.postgresql.org/message-id/b8721722-a73e-0ee9-6513-425e9c88d92f%= 40postgrespro.ru > --000000000000b351520631303f5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 25, 2025, 7:40 PM Dmitry Dol= gov <9erthalion6@gmail.com&= gt; wrote:
=

On Tu= e, Mar 25, 2025, 6:28 PM =C3=81lvaro Herrera <alvherre@alvh.no-ip.o= rg> wrote:
O= n 2025-Mar-25, Tom Lane wrote:
> If this GUC sticks around, it should be at least PGC_SUSET= (on
> the analo= gy of compute_query_id) to make it harder to break
> pg_stat_statements that way.

I have no problem making it superuser-only= , and I can see making "on" be
the default.=C2=A0 I am not opposed to removing it co= mpletely either, if we
really think that the current behavior is no longer useful for=C2=A0any= body.

I'= ;m in favor of removing the GUC of course, but if memory serves there
=
were some folks in the patch discussion thread, who claim= ed they would
need to be able to keep non-squashed b= ehavior. I don't recall if there were
particular= arguments to support that, will try to find those messages again.

<= /div>
Nevermind, I've checked it out -- I think the ca= se I had in mind [1] in fact
supports GUC removal:

> If anyone subtly cha= nges jumbling logic when the extension is
active, the instance could g= et huge performance issues.

--000000000000b351520631303f5f--