MIME-Version: 1.0
References: <E1wRSSY-0012Qd-1Q@gemulon.postgresql.org>
In-Reply-To: <E1wRSSY-0012Qd-1Q@gemulon.postgresql.org>
From: Thom Brown <thom@linux.com>
Date: Tue, 26 May 2026 15:53:34 +0100
Message-ID: 
 <CAA-aLv5pZNZbdhPG2Wu0fzyKCjn9TTzN9QZ=JONPyqZQKhBV=g@mail.gmail.com>
Subject: Re: pgsql: doc: Clarify CHECKPOINT handling of unlogged buffers
To: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA-aLv5pZNZbdhPG2Wu0fzyKCjn9TTzN9QZ%3DJONPyqZQKhBV%3Dg%40mail.gmail.com>
Precedence: bulk

On Mon, 25 May 2026 at 11:23, Daniel Gustafsson
<dgustafsson@postgresql.org> wrote:
>
> doc: Clarify CHECKPOINT handling of unlogged buffers
>
> The CHECKPOINT reference page still described checkpoints as flushing
> all data files, which could be misleading as it depends on the value
> of FLUSH_UNLOGGED option.  Update the description to make it clearer
> that only data files of permanent relations are flushed by default.
>
> Author: Chao Li <lic@highgo.com>
> Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
> Discussion: https://postgr.es/m/4855807D-F1CA-44E6-9B58-406691832848@gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/377cc45194f4f1bd6eb68bd6eb42402e46e326d7
>
> Modified Files
> --------------
> doc/src/sgml/ref/checkpoint.sgml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

"All data for permanent relations files will be flushed to disk, dirty
buffers of unlogged relations are not flushed unless
<literal>FLUSH_UNLOGGED</literal> is specified."

This doesn't quite read right.

"permanent relations files" should be "permanent relation files"

and the sentence looks like it should end after "flushed to disk",
with "Dirty buffers" being the start of a new sentence.

Regards

Thom