Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iNwEk-0001oI-Bp for pgsql-committers@arkaria.postgresql.org; Fri, 25 Oct 2019 09:50:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iNwEj-00018i-3h for pgsql-committers@arkaria.postgresql.org; Fri, 25 Oct 2019 09:50:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iNwEi-00018b-Sl for pgsql-committers@lists.postgresql.org; Fri, 25 Oct 2019 09:50:24 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iNwEg-0003e8-8R for pgsql-committers@lists.postgresql.org; Fri, 25 Oct 2019 09:50:24 +0000 Received: by mail-ot1-x342.google.com with SMTP id c7so1634968otm.3 for ; Fri, 25 Oct 2019 02:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fOlFqzwNN64K5odPPmE7YWqr1JPuJVlbK0SM+QWyG3o=; b=uJTP6vjiQxZCoVi7M1CbfpbIJsY5Giq1doizH/sbEm7Vz75N7X8PpRwGZbQIS2pyQK cnuFY1KFjIYT/DXymlu12Ek1o7bbNjPTehKb1GZHgIvZ1CBzBB4vKDsjy4iiUk6RmFEY opEUhA4syhB5EM5YJEGXeDGvBqViWHSwcAEBH4G5jo+FjKMyPg2nc2UdkBm31cjDkSW8 bFvCZzUmwoWFDia9AKl3iM1ZSxk1SSekVFeZYrWPJvV9UOyw5IhcazXiWl2kRGEMgwF4 nIgjgUbt1xMSjf/5TAXbirLP+nZeq+2Xzcdfx1q4kHvgAyl6SqLd8ZHBGzfs6iJn4mdH hNyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fOlFqzwNN64K5odPPmE7YWqr1JPuJVlbK0SM+QWyG3o=; b=IVPm3w3V/LS3EeHGTogpIC90emeYEZaciKftUn0ueqPSu+jFc59zn7uSl1MN9bzbkd W1YwoAf3H0ZTOybwykAGpNwTRWqD8Zjff/zSiKuypRfIFnQOquA9fWyvTD+AMTf5AJ+E vIi+ZI6BP4hEaz6fazZLxgGj3NZaDkvpyGFcXvVz0NmPmCdV+dgmnQJ6XFwpKuYSsqPw XycuqUuyGTGvaC2RXkOrZJn9dhjehoVqMeZRMwMBadd1L4XeVU3RZq8qxnhy3GvP8vWP hWAtz00BnDHCUQ5Hw1CDkyezDYHK6XM+3PqHph6R4R3YrIAnQ7brVwjdfDWXBLKRxtmT lfQA== X-Gm-Message-State: APjAAAXsLmnsU+PEyuREqPV3ryH0TrKb1aW8NXp2c0CbhEcYa7bhpkWj aMjF9PryRuhaCfFXa3gN32pGIz9NmClNIO6c/RYEuH03ltA= X-Google-Smtp-Source: APXvYqxcwAXmxRqA2mNtfetNK0h67QJ91pkuGM6S2s4IStcQk9zm6MgJvY0GtG85yVLv9jfIYBe+Z0SA7nC+DyVVDk0= X-Received: by 2002:a9d:5190:: with SMTP id y16mr824833otg.103.1571997020561; Fri, 25 Oct 2019 02:50:20 -0700 (PDT) MIME-Version: 1.0 References: <20191025031702.GD8671@paquier.xyz> <87h83xmg4m.fsf@news-spur.riddles.org.uk> In-Reply-To: <87h83xmg4m.fsf@news-spur.riddles.org.uk> From: Amit Kapila Date: Fri, 25 Oct 2019 15:20:09 +0530 Message-ID: Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac To: Andrew Gierth Cc: Michael Paquier , Amit Kapila , pgsql-committers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Fri, Oct 25, 2019 at 1:30 PM Andrew Gierth wrote: > > >>>>> "Amit" == Amit Kapila writes: > > Amit> BTW, prairiedog is also show similar failure and both seems to > Amit> have similar OS except for versions. > > Be aware that prairiedog and locust (unlike the rest of the buildfarm) > have compilers whose "bool" type is not 1 byte long; PG can't use that, > so we don't include on those platforms. > > Looking at c.h, the problem seems to be that when we define our own bool > in the absence of a usable stdbool.h, we do so as a typedef and not a > macro. So pgtypeslib_extern.h ends up redefining it in that case, and > (this bit may be my fault: see d26a810eb) uses a different type to c.h > (char vs. unsigned char). > > (stdbool.h is required by spec to do #define bool _Bool rather than a > typedef, hence the difference in behavior) > > I'm no expert on the ECPG internals, but this doesn't look like an > exposed interface, so maybe it just shouldn't be trying to #define bool > at all and just rely on c.h (from postgres_fe.h) to declare the type? > +1. I think we can discuss this on hackers, so started a thread [1]. [1] - https://www.postgresql.org/message-id/CAA4eK1LmaKO7Du9M9Lo%3DkxGU8sB6aL8fa3sF6z6d5yYYVe3BuQ%40mail.gmail.com -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com