Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnybT-00088A-HP for pgsql-committers@arkaria.postgresql.org; Wed, 15 Mar 2017 02:23:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cnybT-0000uk-46 for pgsql-committers@arkaria.postgresql.org; Wed, 15 Mar 2017 02:23:55 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cnybS-0000ua-OV for pgsql-committers@postgresql.org; Wed, 15 Mar 2017 02:23:54 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cnybP-0002Ij-QB for pgsql-committers@postgresql.org; Wed, 15 Mar 2017 02:23:53 +0000 Received: by mail-wm0-x230.google.com with SMTP id n11so12474999wma.0 for ; Tue, 14 Mar 2017 19:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iFi0TFEduaQk+d7fKsXZ/JyxCe3B2W2fuvnrLy5rQE8=; b=G5tioN9r0b3AhmP1Z0prEz5c4zDtmo24NsEpT5IS3beU1ijWwD3SSOHribsqUpPqhd CROel1y0TF9QcWiGgKbLbwmk3J+yDskZ+hXLD4oxcxT/mqVSAbRG8Dkp3ejSu0t5ceFR wGvBziicdcisXTpzMn+Xu7sCJqGr7QVotvYHbuL6d7d2+VC3AKAchLksGJCKpHIvNbmS KT89tZDGn5sTyCqK2n6xK2AN4K3uqyxi+MLviZVKhvt/00xs9Wcxeo1LyRAe5xrl+tJG T6ObPk/VfnN1kVpg6QaehJi7eO3xeKpj21vNlJ+Fw5h7KtunmEawZJ96J4pyD90V0lQ4 On+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iFi0TFEduaQk+d7fKsXZ/JyxCe3B2W2fuvnrLy5rQE8=; b=fbNK7CdgbEOhtGtRXfxExp7g8zHs/YtS4DBkRjLdGtdyHTszLcl8rUG+qAnw+V1DKU BXmvPZ1vIiO7QTIJ5aah57DuI21iOltUUxQ+DbaWFxPlpcm1EvuTGcHFq0nACh5ZF7b/ PgULG+75BFhrqRlzvJq7leLejqpBYyVAIgEGd/w5Ra0MNYjHe5/hwQEm3OmhKKho8YPg 1XiG1cQvoRSf0xStWVvneXvIDyCCZ6lMypaEhygBGOHxbwxNZKc5ImQvrOC/HPmk24Ha Y52LZtJVBpKTETyJkgnTURdItG6CfM+LytogGN8piP7XzxMppUQ+fDoW5/XxfV/2L+dw hWlA== X-Gm-Message-State: AFeK/H3HT52jGbReFMbpu4JNgJRwh87nIYEaqiDHuOliU5XuGig+oDNQBqHZQzbOeslHekCQ8nNSIP2Uk1ezwA== X-Received: by 10.28.96.194 with SMTP id u185mr2037184wmb.82.1489544630376; Tue, 14 Mar 2017 19:23:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.181.130 with HTTP; Tue, 14 Mar 2017 19:23:49 -0700 (PDT) In-Reply-To: References: <5515.1489514099@sss.pgh.pa.us> From: Amit Kapila Date: Wed, 15 Mar 2017 07:53:49 +0530 Message-ID: Subject: Re: pgsql: hash: Add write-ahead logging support. To: Robert Haas Cc: Tom Lane , pgsql-committers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.5 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On Tue, Mar 14, 2017 at 11:26 PM, Robert Haas wrote: > On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane wrote: >> Robert Haas writes: >>> hash: Add write-ahead logging support. >> >> This bit in access/hash/README, lines 368ff, appears obsolete: >> >> Although we can survive a failure to split a bucket, a crash is likely to >> corrupt the index, since hash indexes are not yet WAL-logged. >> >> Perhaps we can just delete that para. If not, what should it say now? > > That's obsolete, and can just be removed. > Agreed and posted a patch on hackers [1] [1] - https://www.postgresql.org/message-id/CAA4eK1LeVu8rSvA%3DhfbezqjNv5x3nU-rPbHCHHbbsCrLX-0zAg%40mail.gmail.com -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers