Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raoSC-00BZd9-CK for pgsql-committers@arkaria.postgresql.org; Fri, 16 Feb 2024 02:59:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1raoSA-00Gr1Z-MZ for pgsql-committers@arkaria.postgresql.org; Fri, 16 Feb 2024 02:59:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raoSA-00Gr1R-FA for pgsql-committers@lists.postgresql.org; Fri, 16 Feb 2024 02:59:54 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1raoS7-007QtT-Lk for pgsql-committers@lists.postgresql.org; Fri, 16 Feb 2024 02:59:53 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-2185a9966bcso595005fac.0 for ; Thu, 15 Feb 2024 18:59:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708052389; x=1708657189; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6gwbnDnYFYeeNP9BJ2p7TEsRwEecYcidpP85Yoz91Ag=; b=mlpnObtF1hCRehfWyChHfEuEVyW8cbW+mJKSqJohHVSbjPKxFOQmtyquK2hzW0oePe LqrzYLjAZVOlYniJhOPEeqVq4U9pjSEEUvlTlOG53jurf0vHy82QG7fIlO842IZUzeyW f+YEUPiXRIEXOpjv7uwHNlAgAnQpe7hBhutxanKe6mvQ7t5Q+fKG1m4JAMgnjgHRsdTa dIqkbt1xaITG96C17uDxaVphVvv7JH/AolBUS448aJMr+Afdbs0FiQpEzeubM2zY7MTZ 81rUFG+hn0+fLwyRdJ8X4wvav5a1Fd1l3CZrb/sTg/kBVfkq+c+FzPzOaVqspF8YVpmJ WJYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708052389; x=1708657189; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6gwbnDnYFYeeNP9BJ2p7TEsRwEecYcidpP85Yoz91Ag=; b=flZK4GZvC1osHc1276FFxy+NtN9WguB0qdoSA8XGHQDU+UCDkKBkghqDeVNEWOSntE Zm+rf2YcSQkbp3LiyjMyvoV5dzty3utotlpBZjDUksbU8Y26BNzMJpKgMoLDPgpgQupU ahqPXnDcrfdNEjlWqhJYtymlfQ9+6oCe5sl2tZPdAst9bSJnRsdAcf490I/zJeZf6nys zAABoaFvKmX70YrClBL4v3FKQ+HeDRDp30dDfJ+4AMk1dQWPI1vxp01/eRM+bR7yRg2b Vnp+8jFYL9gkEg2/WuNvMEzPd6rQNctMI2tImZvixAqVK/o1jL03N5TXFd4V9HZat9jM LimA== X-Forwarded-Encrypted: i=1; AJvYcCWmYgz699wZSpwEqbIfN5Dnkx0lGrtY5GLuXbUlOtnLJjCbOiUF7xG1tgjdm+wWZZpfgYFmaBs3hncGMJSZYri8FsrhSZZdUEvPdV2UEivU24Iobond X-Gm-Message-State: AOJu0Yw7m2NFRjGDxH3EOyphU+3FRXseaUko73bD+442h0Z4pfMF2SwF nVJwdDY3PPhJugLFNVk8ynsrceWxMG2jRpYqzVnyyNvi4k+w7RKxrS3LFZWTbEmYY9wMU72g0yJ khy3tp1DELx0Yx8TyBhccZ2uMO+x5SVZrkUBxkw== X-Google-Smtp-Source: AGHT+IHy9xVcpDR9EGh2Z5ka/TfV14iqRYP6vfB8Ih1kb0XOO6ZPFymBwqiaZeiMlRpM7kzbdPqIwWLmchOFyDsH9QQ= X-Received: by 2002:a05:6870:1586:b0:21e:3977:417 with SMTP id j6-20020a056870158600b0021e39770417mr1563647oab.14.1708052389490; Thu, 15 Feb 2024 18:59:49 -0800 (PST) MIME-Version: 1.0 References: <25f7f4bf-9e75-4453-b666-7818000cefe6@eisentraut.org> In-Reply-To: <25f7f4bf-9e75-4453-b666-7818000cefe6@eisentraut.org> From: Amit Kapila Date: Fri, 16 Feb 2024 08:29:38 +0530 Message-ID: Subject: Re: pgsql: Allow upgrades to preserve the full subscription's state. To: Peter Eisentraut Cc: Amit Kapila , pgsql-committers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Feb 15, 2024 at 7:15=E2=80=AFPM Peter Eisentraut wrote: > > On 02.01.24 04:07, Amit Kapila wrote: > > Allow upgrades to preserve the full subscription's state. > > The added test src/bin/pg_upgrade/t/004_subscription.pl does not pass whe= n > > export PG_TEST_PG_UPGRADE_MODE=3D--link > > is set. > > Could you check whether that could be fixed, or otherwise if the test > needs to be skipped in that case? > Thanks for the report. We are working on a fix for it [1]. [1] - https://www.postgresql.org/message-id/TYCPR01MB120773E8D02D58F50B24DA= 6ADF54E2%40TYCPR01MB12077.jpnprd01.prod.outlook.com --=20 With Regards, Amit Kapila.