MIME-Version: 1.0
References: <E1tlBJt-000LUO-16@gemulon.postgresql.org>
 <003dc9936317ab987faa0242f8e33e1cd2fcaf57.camel@j-davis.com>
 <40c1e76334f2baa747334c8fc513d12b8cb297bf.camel@j-davis.com>
 <3815127.1740189601@sss.pgh.pa.us>
 <5ebc188e731ac2b98d68459ce1a9ef3066981774.camel@j-davis.com>
 <3892121.1740193866@sss.pgh.pa.us>
 <976dcc37-b629-490e-a052-a057477d062f@dunslane.net>
 <301492.1740249291@sss.pgh.pa.us> <684274.1740273302@sss.pgh.pa.us>
 <812817.1740277228@sss.pgh.pa.us>
 <10bd5e38-c8e1-4162-8dd7-ef65e71170b4@dunslane.net>
 <1144186.1740338230@sss.pgh.pa.us>
 <CAA5RZ0u9dV3CdKqkqdusA_RdvBkwWe0c0rxcFWj++VYoutFYSw@mail.gmail.com>
 <2768649.1740765297@sss.pgh.pa.us>
 <CAA5RZ0udD=7o6pjBSiEEzN60Jd3X1=vrXed+0YivYCVrqvav=Q@mail.gmail.com>
 <CAA5RZ0vgx8n98dcybr16V5mECEJRruBLMgDoVpmtpG+5D+5VPg@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0vgx8n98dcybr16V5mECEJRruBLMgDoVpmtpG+5D+5VPg@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Fri, 28 Feb 2025 13:29:16 -0600
Message-ID: 
 <CAA5RZ0tz-AibaxVF1NnNMcMEmwut+kn=k=xG2XmDN9d6kv2-=g@mail.gmail.com>
Subject: Re: pgsql: Trial fix for old cross-version upgrades.
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Jeff Davis <pgsql@j-davis.com>,
	Jeff Davis <jdavis@postgresql.org>, pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0tz-AibaxVF1NnNMcMEmwut%2Bkn%3Dk%3DxG2XmDN9d6kv2-%3Dg%40mail.gmail.com>
Precedence: bulk

My perl expertise is bit shallow, but I could not find much
regarding bugs related to such behavior, or maybe I did not
look enough.

Playing around with this, "s+", "s{1,}", s{2,}" all of these combinations
where we are searching for more than 1 space result in the hanging command,
but we really only need to look for a single space before the 'version',
so maybe we can just do the below, which works?

-       $dump =~ s {(^\s+'version',) '\d+'::integer,$}
+      $dump =~ s {(^\s{1}'version',) '\d+'::integer,$}

-- 
Sami