MIME-Version: 1.0
References: <1282250.1742921593@sss.pgh.pa.us>
 <202503251727.pn3eg43zqkdk@alvherre.pgsql>
In-Reply-To: <202503251727.pn3eg43zqkdk@alvherre.pgsql>
From: Sami Imseih <samimseih@gmail.com>
Date: Tue, 25 Mar 2025 12:55:58 -0500
Message-ID: 
 <CAA5RZ0v5VqUo_ew-fNA1HDF4Lo=7UtEyoT_SYOPjYFcjmDfE2Q@mail.gmail.com>
Subject: Re: Squash constant lists in query jumbling by default
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Christoph Berg <myon@debian.org>,
	pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>,
	Julien Rouhaud <rjuju123@gmail.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0v5VqUo_ew-fNA1HDF4Lo%3D7UtEyoT_SYOPjYFcjmDfE2Q%40mail.gmail.com>
Precedence: bulk

> > If this GUC sticks around, it should be at least PGC_SUSET (on
> > the analogy of compute_query_id) to make it harder to break
> > pg_stat_statements that way.
>
> I have no problem making it superuser-only, and I can see making "on" be
> the default.  I am not opposed to removing it completely either, if we
> really think that the current behavior is no longer useful for anybody.

I am in favor of complete removal. [1] will change the behavior of table
jumbling without introducing a GUC, and I don't think we should introduce
a GUC for the squash values case either. Why one behavior change is configurable
while the other is not? seems confusing, IMO.

Also, as a matter of principle, it seems most are favoring not
introducing GUCs to
configure queryId behavior. I agree.

[1] https://www.postgresql.org/message-id/flat/CAA5RZ0uNofEXfEfNw3uRN3D3oXkFPQ_s%2BhuLLHMKR_%2BMCk8RPQ%40mail.gmail.com#c357c56c3924642e8ef73cc1c8a0286e

--
Sami Imseih
Amazon Web Services (AWS)