MIME-Version: 1.0
References: <E1w3fZp-000gje-31@gemulon.postgresql.org> <d82e0127-8f18-4231-98df-cae0e6cd4ad2@eisentraut.org>
In-Reply-To: <d82e0127-8f18-4231-98df-cae0e6cd4ad2@eisentraut.org>
From: Amul Sul <sulamul@gmail.com>
Date: Mon, 4 May 2026 16:46:24 +0530
Message-ID: <CAAJ_b95pj6rq4yw09Ds-7x8-HLHFbseJEXag5TDPb_CZewBgRA@mail.gmail.com>
Subject: Re: pgsql: pg_verifybackup: Enable WAL parsing for tar-format backups
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-committers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000f6fd190650fc11c3"
Archived-At: <https://www.postgresql.org/message-id/CAAJ_b95pj6rq4yw09Ds-7x8-HLHFbseJEXag5TDPb_CZewBgRA%40mail.gmail.com>
Precedence: bulk

--000000000000f6fd190650fc11c3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 4, 2026 at 3:00=E2=80=AFPM Peter Eisentraut <peter@eisentraut.o=
rg> wrote:
>
> On 20.03.26 20:32, Andrew Dunstan wrote:
> > pg_verifybackup: Enable WAL parsing for tar-format backups
> >
> > Now that pg_waldump supports reading WAL from tar archives, remove the
> > restriction that forced --no-parse-wal for tar-format backups.
> >
> > pg_verifybackup now automatically locates the WAL archive: it looks for
> > a separate pg_wal.tar first, then falls back to the main base.tar.  A
> > new --wal-path option (replacing the old --wal-directory, which is kept
> > as a silent alias) accepts either a directory or a tar archive path.
>
> In the past, we have opted against silent aliases when changing a
> command-line option.  All options should be documented, even if they are
> deprecated.  Otherwise, it's confusing for users moving between major
> versions or those who find that undocumented options happen to work.
> See commit 35ce24c333c for an example how this was done in the past.
>
> I suggest the option --wal-directory should be added back to the
> documentation and help output.

Agreed. Attached is a quick fix.

Regards,
Amul

--000000000000f6fd190650fc11c3
Content-Type: application/octet-stream; 
	name="0001-Document-deprecated-wal-directory-option-for-pg_veri.patch"
Content-Disposition: attachment; 
	filename="0001-Document-deprecated-wal-directory-option-for-pg_veri.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mor3t6re0>
X-Attachment-Id: f_mor3t6re0

RnJvbSBkNGFhNGQ0ZmYyZGEyMDdjNGJmZDhmZmViMGMwM2RjZTZhN2NhYjY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbXVsIFN1bCA8c3VsYW11bEBnbWFpbC5jb20+CkRhdGU6IE1v
biwgNCBNYXkgMjAyNiAxNjo0MDo0NiArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIERvY3VtZW50IGRl
cHJlY2F0ZWQgLS13YWwtZGlyZWN0b3J5IG9wdGlvbiBmb3IKIHBnX3ZlcmlmeWJhY2t1cApNSU1F
LVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29u
dGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQ29tbWl0IGIzY2Y0NjFiM2NmOTFjNTg2YWI5
NGI0ZGRkZDZkY2Q4ZmY4ZmVjNDcgcmVuYW1lZAotLXdhbC1kaXJlY3RvcnkgdG8gLS13YWwtcGF0
aCBidXQgcmV0YWluZWQgdGhlIGZvcm1lciBhcyBhIHNpbGVudAphbGlhcy4gUGVyIHByb2plY3Qg
cG9saWN5LCBhbGwgb3B0aW9uc+KAlGluY2x1ZGluZyBkZXByZWNhdGVkCm9uZXPigJRzaG91bGQg
YmUgZG9jdW1lbnRlZCB0byBhc3Npc3QgdXNlcnMgdHJhbnNpdGlvbmluZyBiZXR3ZWVuCnZlcnNp
b25zLgoKVGhpcyBwYXRjaCByZXN0b3JlcyAtLXdhbC1kaXJlY3RvcnkgdG8gdGhlIGRvY3VtZW50
YXRpb24gYW5kIC0taGVscApvdXRwdXQuCi0tLQogZG9jL3NyYy9zZ21sL3JlZi9wZ192ZXJpZnli
YWNrdXAuc2dtbCAgICAgfCAxICsKIHNyYy9iaW4vcGdfdmVyaWZ5YmFja3VwL3BnX3ZlcmlmeWJh
Y2t1cC5jIHwgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp
dCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdfdmVyaWZ5YmFja3VwLnNnbWwgYi9kb2Mvc3JjL3NnbWwv
cmVmL3BnX3ZlcmlmeWJhY2t1cC5zZ21sCmluZGV4IDE2OTVjZmU5MWM4Li4wNDU1MTY0NjRhNCAx
MDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9wZ192ZXJpZnliYWNrdXAuc2dtbAorKysgYi9k
b2Mvc3JjL3NnbWwvcmVmL3BnX3ZlcmlmeWJhY2t1cC5zZ21sCkBAIC0yNTksNiArMjU5LDcgQEAg
UG9zdGdyZVNRTCBkb2N1bWVudGF0aW9uCiAgICAgIDx2YXJsaXN0ZW50cnk+CiAgICAgICA8dGVy
bT48b3B0aW9uPi13IDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj5wYXRoPC9yZXBsYWNl
YWJsZT48L29wdGlvbj48L3Rlcm0+CiAgICAgICA8dGVybT48b3B0aW9uPi0td2FsLXBhdGg9PHJl
cGxhY2VhYmxlIGNsYXNzPSJwYXJhbWV0ZXIiPnBhdGg8L3JlcGxhY2VhYmxlPjwvb3B0aW9uPjwv
dGVybT4KKyAgICAgIDx0ZXJtPjxvcHRpb24+LS13YWwtZGlyZWN0b3J5PTxyZXBsYWNlYWJsZSBj
bGFzcz0icGFyYW1ldGVyIj5wYXRoPC9yZXBsYWNlYWJsZT48L29wdGlvbj4gKGRlcHJlY2F0ZWQp
PC90ZXJtPgogICAgICAgPGxpc3RpdGVtPgogICAgICAgIDxwYXJhPgogICAgICAgICBUcnkgdG8g
cGFyc2UgV0FMIGZpbGVzIHN0b3JlZCBpbiB0aGUgc3BlY2lmaWVkIGRpcmVjdG9yeSBvciB0YXIK
ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfdmVyaWZ5YmFja3VwL3BnX3ZlcmlmeWJhY2t1cC5jIGIv
c3JjL2Jpbi9wZ192ZXJpZnliYWNrdXAvcGdfdmVyaWZ5YmFja3VwLmMKaW5kZXggYjYwYWI4NzM5
ZDUuLjQ4MDlhOGI5MWU2IDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX3ZlcmlmeWJhY2t1cC9wZ192
ZXJpZnliYWNrdXAuYworKysgYi9zcmMvYmluL3BnX3ZlcmlmeWJhY2t1cC9wZ192ZXJpZnliYWNr
dXAuYwpAQCAtMTM5OSw2ICsxMzk5LDcgQEAgdXNhZ2Uodm9pZCkKIAlwcmludGYoXygiICAtcSwg
LS1xdWlldCAgICAgICAgICAgICAgICAgZG8gbm90IHByaW50IGFueSBvdXRwdXQsIGV4Y2VwdCBm
b3IgZXJyb3JzXG4iKSk7CiAJcHJpbnRmKF8oIiAgLXMsIC0tc2tpcC1jaGVja3N1bXMgICAgICAg
IHNraXAgY2hlY2tzdW0gdmVyaWZpY2F0aW9uXG4iKSk7CiAJcHJpbnRmKF8oIiAgLXcsIC0td2Fs
LXBhdGg9UEFUSCAgICAgICAgIHVzZSBzcGVjaWZpZWQgcGF0aCBmb3IgV0FMIGZpbGVzXG4iKSk7
CisJcHJpbnRmKF8oIiAgLS13YWwtZGlyZWN0b3J5PVBBVEggICAgICAgIChzYW1lIGFzIC0td2Fs
LXBhdGgsIGRlcHJlY2F0ZWQpXG4iKSk7CiAJcHJpbnRmKF8oIiAgLVYsIC0tdmVyc2lvbiAgICAg
ICAgICAgICAgIG91dHB1dCB2ZXJzaW9uIGluZm9ybWF0aW9uLCB0aGVuIGV4aXRcbiIpKTsKIAlw
cmludGYoXygiICAtPywgLS1oZWxwICAgICAgICAgICAgICAgICAgc2hvdyB0aGlzIGhlbHAsIHRo
ZW4gZXhpdFxuIikpOwogCXByaW50ZihfKCJcblJlcG9ydCBidWdzIHRvIDwlcz4uXG4iKSwgUEFD
S0FHRV9CVUdSRVBPUlQpOwotLSAKMi40Ny4xCgo=
--000000000000f6fd190650fc11c3--