public inbox for [email protected]
help / color / mirror / Atom feedFrom: Melanie Plageman <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Add relallfrozen to pg_class
Date: Mon, 3 Mar 2025 11:48:18 -0500
Message-ID: <CAAKRu_Z_W+Fc92onBM7LmeFs0+Dcu4A7K_e5m6LMMn9biV+_xw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Mon, Mar 3, 2025 at 11:44 AM Álvaro Herrera <[email protected]> wrote:
>
> On 2025-Mar-03, Melanie Plageman wrote:
>
> > relallfrozen, together with relallvisible, is useful for estimating the
> > outstanding number of all-visible but not all-frozen pages in the
> > relation for the purposes of scheduling manual VACUUMs and tuning vacuum
> > freeze parameters.
>
> I'm confused about this. Why was the new value added to pg_class
> instead of to the pgstat system? I don't think relallvisible is a good
> precedent, because as you write here, that one is used for planning,
> which has different requirements. For vacuuming metrics we rely on
> pgstat.
We use relpages and reltuples from pg_class in
relation_needs_vacanalyze() in the same way relallfrozen is being used
here.
If we don't want relallfrozen in pg_class then there is no reason we
wouldn't also move relallvisible out of pg_class too.
- Melanie
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgsql: Add relallfrozen to pg_class
In-Reply-To: <CAAKRu_Z_W+Fc92onBM7LmeFs0+Dcu4A7K_e5m6LMMn9biV+_xw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox