Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tp92G-0012VM-SJ for pgsql-committers@arkaria.postgresql.org; Mon, 03 Mar 2025 16:52:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tp92F-00BsZr-Kc for pgsql-committers@arkaria.postgresql.org; Mon, 03 Mar 2025 16:52:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tp92F-00BsZj-Bw for pgsql-committers@lists.postgresql.org; Mon, 03 Mar 2025 16:52:55 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tp92D-000kW7-0o for pgsql-committers@lists.postgresql.org; Mon, 03 Mar 2025 16:52:54 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e535e6739bso2740324a12.1 for ; Mon, 03 Mar 2025 08:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741020772; x=1741625572; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TwuqPmxof697MYs4Q8qHhxZ4qxAKihPaVLrQ+lkz7Vw=; b=Xb6F+2q4lwsnGSGnMqFqkfyHkf9JLHNbRcQkwIYlvuRgndRj6pNXM32FW6U0pmAYMX IneIzi9TMlyoB+8s1vpX1592eDWQyjvB4g5Xzfw/pgvXSuMqnF1pkU1VrgLQGfDRKP08 W3lEazxynsf2S78hm4KSkjjXoDHzm5b77X3ck7AtI5GJlo1umuCHO2z3Ray8JUELRPrq lt7FN6QZUGN6f2XPicMl+3AyL6kKeZBFfwVk0v4bayVhV94FBrfnts9+WhYBNudXtO1I GznVFH4Vix1LdXeRLkmABIl/iQjcumGbN9kflH0dgULvf1ThYhKkXWv7cqK3FHmDSyh2 2EYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741020772; x=1741625572; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TwuqPmxof697MYs4Q8qHhxZ4qxAKihPaVLrQ+lkz7Vw=; b=oI/Rl08g9yXuAbqIH077RIKHseDLT6BnhzBo5Rj5IAPRtQY6p+oTQVMUgc5e6ZgDDB ov4sxdEcElNVJUc1C5MFC1r+VgMcguQ3CzCMNvWu2FVDmdSMiw1ueYkNxGE+P1S1w48b jcwpWwCJP8f8Kuyr111XdYNGz0VN6OO9vuZBj1VC+0WSy6BJLVUVa1pOEjkQbe1eAadJ RRpH66gVu6KFTpnDurjL/ic6JDzUHtyWXfzb7YMpVagTm0vX0BjuTonfCeXa7LkZrxTx gPn7w9oyrfhgY90NC5NMhKhx26VHXmk8cMtoZuQ7mzTRfbJhc5nED7WIDb3asRvUEhOD 8InA== X-Gm-Message-State: AOJu0YzMnIt0M7fUoFrXnNw8qmRCWnh21lowf3vgE+fCQaSWUR1XiP/+ perqPsME1evW7Z39hC4WPaDl/htYWYhJrcqYjGxKsCPjsZnzpk76zPcEoOGQqp6lreYqM1+f9Nl 54VTesymkhTtjHX5SzNTkSW4al11Z9g== X-Gm-Gg: ASbGncsu9e4ylGSRAD+XOMKQDV5NjAX3buRB7TxefzqB9eCOmdqOwYRNUhNibErUvDh ViZSnuWoUzDKfTG0vGZ5ug229upbRuetyQW41XuKl+YekG1bFP/RV0MUHfWDgXtpwlvl0qzSTYa AlcFJ0BmSOxjGpBRhIRwJo2WdXHd/TvRIz1yDJ3uF8K8J3nGOt7ttFjoRreG8k X-Google-Smtp-Source: AGHT+IGZ+VsoflNxRAE4ohv/X+03+dJHNUOL4NnkGwG81HpvbbOOEzBRH8Cf/HnjtWkYrtxckW7OMF3NhQfoUqOLbzw= X-Received: by 2002:a05:6402:4409:b0:5dc:7725:a0c7 with SMTP id 4fb4d7f45d1cf-5e4d6adbd19mr17003366a12.3.1741020771596; Mon, 03 Mar 2025 08:52:51 -0800 (PST) MIME-Version: 1.0 References: <202503031644.nihftaytey2b@alvherre.pgsql> In-Reply-To: From: Melanie Plageman Date: Mon, 3 Mar 2025 11:52:40 -0500 X-Gm-Features: AQ5f1Jp4xCQh2lV-jWq7ww3TJILAtWshW7l6GYYyhbsrDBGT2SIMtBN-Wjvh1Hk Message-ID: Subject: Re: pgsql: Add relallfrozen to pg_class To: =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: pgsql-committers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Mar 3, 2025 at 11:48=E2=80=AFAM Melanie Plageman wrote: > > On Mon, Mar 3, 2025 at 11:44=E2=80=AFAM =C3=81lvaro Herrera wrote: > > > > I'm confused about this. Why was the new value added to pg_class > > instead of to the pgstat system? I don't think relallvisible is a good > > precedent, because as you write here, that one is used for planning, > > which has different requirements. For vacuuming metrics we rely on > > pgstat. > > We use relpages and reltuples from pg_class in > relation_needs_vacanalyze() in the same way relallfrozen is being used > here. Sorry reltuples only (not relpages). - Melanie