MIME-Version: 1.0
References: <E1roXs4-005UdX-1V@gemulon.postgresql.org>
In-Reply-To: <E1roXs4-005UdX-1V@gemulon.postgresql.org>
From: David Rowley <dgrowleyml@gmail.com>
Date: Mon, 25 Mar 2024 14:58:15 +1300
Message-ID: 
 <CAApHDvopqUZA2ZLR2YawKWeztJohPxgjjwhXvckU-OOAwHPZoA@mail.gmail.com>
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
To: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvopqUZA2ZLR2YawKWeztJohPxgjjwhXvckU-OOAwHPZoA%40mail.gmail.com>
Precedence: bulk

On Mon, 25 Mar 2024 at 13:07, Alexander Korotkov
<akorotkov@postgresql.org> wrote:
> reindexdb: Add the index-level REINDEX with multiple jobs

This seems to cause a new compiler warning:

reindexdb.c: In function =E2=80=98reindex_one_database=E2=80=99:
reindexdb.c:437:45: warning: =E2=80=98indices_tables_cell=E2=80=99 may be u=
sed
uninitialized [-Wmaybe-uninitialized]
  437 |                         indices_tables_cell =3D indices_tables_cell=
->next;
      |                         ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~=
~~~~
reindexdb.c:280:31: note: =E2=80=98indices_tables_cell=E2=80=99 was declare=
d here
  280 |         SimpleStringListCell *indices_tables_cell;
      |                               ^~~~~~~~~~~~~~~~~~~

which is causing problems in -Werror buildfarm members like mamba [1]

David

 [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmamba&dt=3D2=
024-03-25%2001%3A03%3A35