MIME-Version: 1.0
References: <E1ts2ug-001xVQ-04@gemulon.postgresql.org>
 <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
 <6c00a8b2-0c40-44f0-b603-f6ae28b7694a@eisentraut.org>
 <CAApHDvqf4tKwE0oP8ybL2Eu-SD=C34pdZ9vVDSJwvqDXi88nUg@mail.gmail.com>
 <dc9665a8-987a-443d-ab18-f9865d21d034@eisentraut.org>
 <CAApHDvrFdXjbrV6KCx_GHKYSufUbNDYSsjppcJQiGOURfJE6qg@mail.gmail.com>
 <1244428.1752677780@sss.pgh.pa.us>
 <CAApHDvoOnd4PBNV0qyJVLmbWvWUjztzcMH5xY2AGp5Vov6XU3Q@mail.gmail.com>
 <1330026.1752722396@sss.pgh.pa.us>
In-Reply-To: <1330026.1752722396@sss.pgh.pa.us>
From: David Rowley <dgrowleyml@gmail.com>
Date: Thu, 17 Jul 2025 16:09:18 +1200
Message-ID: 
 <CAApHDvp-WCUTDU767Lpjw3m698gS+mCrNAnTEppZiXixneVxGQ@mail.gmail.com>
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a
 directory p
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Masahiko Sawada <msawada@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000001afee9063a182d97"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvp-WCUTDU767Lpjw3m698gS%2BmCrNAnTEppZiXixneVxGQ%40mail.gmail.com>
Precedence: bulk

--0000000000001afee9063a182d97
Content-Type: text/plain; charset="UTF-8"

On Thu, 17 Jul 2025 at 15:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > I spent a bit more time searching for a solution and did find
> > something that works well enough for this case in [1]. Unfortunately,
> > it only works with C11. See attached .c file and output below.
>
> Hmph.  I doubt we are ready to require C11 everywhere, but maybe
> we could require it in MSVC builds?  Which MSVC versions would
> that eliminate?

Going by [1] it's Visual Studio 2019, which as of 8fd9bb1d9 is now our
minimum supported VS version.

I hacked up a quick patch (attached) which compiles without any
warnings.  Tested on VS2012 with meson setup -Dc_std=c11.

Unsure what other repercussions there are of compiling with C11 and
have not looked into what it would take to adjust the meson build
scripts to default to that for MSVC builds.

David

[1] https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriving-in-msvc/

--0000000000001afee9063a182d97
Content-Type: application/octet-stream;
	name="v1-0001-Detect-elog-ERROR-can-t-return-in-MSVC-when-using.patch"
Content-Disposition: attachment;
	filename="v1-0001-Detect-elog-ERROR-can-t-return-in-MSVC-when-using.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_md6vbxqf0>
X-Attachment-Id: f_md6vbxqf0

RnJvbSBlNGNlZDkzYjJjMzVkYjkxY2IyOGY1NjQxMDNhNzIzOGVmZDcyYjQzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBSb3dsZXkgPGRncm93bGV5QGdtYWlsLmNvbT4KRGF0
ZTogVGh1LCAxNyBKdWwgMjAyNSAxNTo0OTowMyArMTIwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIERl
dGVjdCBlbG9nKEVSUk9SKSBjYW4ndCByZXR1cm4gaW4gTVNWQyB3aGVuIHVzaW5nIEMxMQoKLS0t
CiBzcmMvYmFja2VuZC9iYWNrdXAvYmFzZWJhY2t1cF90YXJnZXQuYyB8ICAyICstCiBzcmMvaW5j
bHVkZS91dGlscy9lbG9nLmggICAgICAgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKy0KIDIg
ZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9zcmMvYmFja2VuZC9iYWNrdXAvYmFzZWJhY2t1cF90YXJnZXQuYyBiL3NyYy9iYWNrZW5k
L2JhY2t1cC9iYXNlYmFja3VwX3RhcmdldC5jCmluZGV4IDg0YjEzMDlkM2JkLi4wYjQ4NTIxZjEw
NCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYmFja3VwL2Jhc2ViYWNrdXBfdGFyZ2V0LmMKKysr
IGIvc3JjL2JhY2tlbmQvYmFja3VwL2Jhc2ViYWNrdXBfdGFyZ2V0LmMKQEAgLTE0Niw3ICsxNDYs
NyBAQCBCYXNlQmFja3VwR2V0VGFyZ2V0SGFuZGxlKGNoYXIgKnRhcmdldCwgY2hhciAqdGFyZ2V0
X2RldGFpbCkKIAkJCSBlcnJtc2coInVucmVjb2duaXplZCB0YXJnZXQ6IFwiJXNcIiIsIHRhcmdl
dCkpKTsKIAogCS8qIGtlZXAgY29tcGlsZXIgcXVpZXQgKi8KLQlyZXR1cm4gTlVMTDsKKwkvL3Jl
dHVybiBOVUxMOwogfQogCiAvKgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvdXRpbHMvZWxvZy5o
IGIvc3JjL2luY2x1ZGUvdXRpbHMvZWxvZy5oCmluZGV4IDY3NWY0ZjVmNDY5Li5jOTNiYTgyZWNm
OCAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvdXRpbHMvZWxvZy5oCisrKyBiL3NyYy9pbmNsdWRl
L3V0aWxzL2Vsb2cuaApAQCAtMTM3LDcgKzEzNywyMSBAQCBzdHJ1Y3QgTm9kZTsKICAqIHByZXZl
bnRzIGdjYyBmcm9tIG1ha2luZyB0aGUgdW5yZWFjaGFiaWxpdHkgZGVkdWN0aW9uIGF0IG9wdGxl
dmVsIC1PMC4KICAqLS0tLS0tLS0tLQogICovCi0jaWZkZWYgSEFWRV9fQlVJTFRJTl9DT05TVEFO
VF9QCisKKyNpZiBkZWZpbmVkKF9NU0NfVkVSKSAmJiBkZWZpbmVkKF9fU1REQ19WRVJTSU9OX18p
ICYmIF9fU1REQ19WRVJTSU9OX18gPj0gMjAxMTEyCisjZGVmaW5lIHBnX2J1aWx0aW5fY29uc3Rh
bnQoeCkgXAorCV9HZW5lcmljKCgxID8gKCh2b2lkKikoKHgpKih1aW50cHRyX3QpMCkpIDogJihp
bnQpezF9KSwgaW50KjogMSwgdm9pZCo6IDApCisjZGVmaW5lIGVyZXBvcnRfZG9tYWluKGVsZXZl
bCwgZG9tYWluLCAuLi4pCVwKKwlkbyB7IFwKKwkJcGdfcHJldmVudF9lcnJub19pbl9zY29wZSgp
OyBcCisJCWlmIChwZ19idWlsdGluX2NvbnN0YW50KGVsZXZlbCkgJiYgKGVsZXZlbCkgPj0gRVJS
T1IgPyBcCisJCQllcnJzdGFydF9jb2xkKGVsZXZlbCwgZG9tYWluKSA6IFwKKwkJCWVycnN0YXJ0
KGVsZXZlbCwgZG9tYWluKSkgXAorCQkJX19WQV9BUkdTX18sIGVycmZpbmlzaChfX0ZJTEVfXywg
X19MSU5FX18sIF9fZnVuY19fKTsgXAorCQlpZiAocGdfYnVpbHRpbl9jb25zdGFudChlbGV2ZWwp
ICYmIChlbGV2ZWwpID49IEVSUk9SKSBcCisJCQlwZ191bnJlYWNoYWJsZSgpOyBcCisJfSB3aGls
ZSgwKQorI2VsaWYgZGVmaW5lZChIQVZFX19CVUlMVElOX0NPTlNUQU5UX1ApCiAjZGVmaW5lIGVy
ZXBvcnRfZG9tYWluKGVsZXZlbCwgZG9tYWluLCAuLi4pCVwKIAlkbyB7IFwKIAkJcGdfcHJldmVu
dF9lcnJub19pbl9zY29wZSgpOyBcCi0tIAoyLjQwLjEud2luZG93cy4xCgo=
--0000000000001afee9063a182d97--