Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nouEb-0003tX-TT for pgsql-committers@arkaria.postgresql.org; Wed, 11 May 2022 21:51:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nouEY-0004px-Rl for pgsql-committers@arkaria.postgresql.org; Wed, 11 May 2022 21:51:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nouEY-0004ow-Ig for pgsql-committers@lists.postgresql.org; Wed, 11 May 2022 21:51:02 +0000 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nouES-0006GP-2w for pgsql-committers@lists.postgresql.org; Wed, 11 May 2022 21:51:01 +0000 Received: by mail-ot1-x333.google.com with SMTP id m15-20020a9d608f000000b00606a788887aso1391236otj.0 for ; Wed, 11 May 2022 14:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZMZ+emzgCOkaYXSE0slm1bJZWM/K0tPScKtBGDNVoDs=; b=E94CgaY5HInA8objJZClgQVwsEIe5j8dqc1jcmeMLgqvIIOj44ZDKOnfppcWXPBNrw /WeXBDE4zSp9lIvNUm+cZcSK4yCgYiQ0V/20ik8uvvUcSZiKwX6DuvllLK6I5dThtpSb bfThDlTki+NNdNOVgvjW2Ri5gF91mbBODGBYbD2L6z+urQ8odMNYS1QMlhsApst9tLUW Yn9P6ug255x8GEhNGu3sxyf79Hj1RnocPOUxdOSonIXnyyRqcEqN4rqmcbPf0irvCSsc eOblhavAAWV6+5PigyRmz/3vOH//5JB2rBdcjne47EHgSowhiQ4HiAM9mueasAj29yA0 21UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZMZ+emzgCOkaYXSE0slm1bJZWM/K0tPScKtBGDNVoDs=; b=Mhl9inxGiVNG8+8zUHmRRPBtspyfgu2xEu/HvgK0kH+mUksZiJUC7gThUeWYNkaulw Zgbf70rKl/ydx5toJ2JEdA3t4CXxxPuQDm282jNRQGSBJaIpHnDz32hsitE+q3VQZ9fy FlNSWq2RrW9PXPsDCmeAAtkPgvxti3mgw/g59TMq1SlIfbR7Wfn2/Ynye8n8K3LeGC68 Fv4UWifvjt95/zUAb61WObPyNaJqTzo+B/zHlsWkNsMbuzdE839qZHlOV54S5A5XrT8W 3aRC5hScFAa7fe7TPZdb6RO+TTeo43eOLFnRdfvcJt87TTmN2NLzXEuGRoHK+WKl6fnx XjVA== X-Gm-Message-State: AOAM531RBziES34FondPtsb8ExsvuTnswXe+PvN2+al/f5hVArRf2AJ3 fR+GIP4zQ5CzezHXbKD0oB0nKL00fYvNa+zeNjE= X-Google-Smtp-Source: ABdhPJwSMkmtHCUV2qMKSF0Rl2I2p952y5KtpI8iDLgsEZ1c5jVrmdaSwJ2ekFjzpHb7uKxSKJMYZSAuYKygjMzKLrE= X-Received: by 2002:a9d:5184:0:b0:605:ea2e:72cb with SMTP id y4-20020a9d5184000000b00605ea2e72cbmr10659683otg.234.1652305854870; Wed, 11 May 2022 14:50:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Rowley Date: Thu, 12 May 2022 09:50:38 +1200 Message-ID: Subject: Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated To: John Naylor Cc: John Naylor , pgsql-committers@lists.postgresql.org, Thomas Munro Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 11 May 2022 at 20:42, John Naylor wrote: > (I don't have a > 32-bit platform to test on) I had to do as Michael mentioned yesterday to test this. FWIW, I compiled and ran the tests on my machine with -m32 and no compile or test failures. Also, looking at the patch, it seems fine to me. Do you want to push it? David