MIME-Version: 1.0
References: <E1ts2ug-001xVQ-04@gemulon.postgresql.org>
 <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
 <6c00a8b2-0c40-44f0-b603-f6ae28b7694a@eisentraut.org>
In-Reply-To: <6c00a8b2-0c40-44f0-b603-f6ae28b7694a@eisentraut.org>
From: David Rowley <dgrowleyml@gmail.com>
Date: Wed, 12 Mar 2025 21:37:35 +1300
Message-ID: 
 <CAApHDvqf4tKwE0oP8ybL2Eu-SD=C34pdZ9vVDSJwvqDXi88nUg@mail.gmail.com>
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a
 directory p
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Masahiko Sawada <msawada@postgresql.org>,
 pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvqf4tKwE0oP8ybL2Eu-SD%3DC34pdZ9vVDSJwvqDXi88nUg%40mail.gmail.com>
Precedence: bulk

On Wed, 12 Mar 2025 at 21:15, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 12.03.25 03:08, David Rowley wrote:
> > This introduces a new compiler warning for compilers that don't know
> > the ereport(ERROR) does not return.
>
> Which compiler is that?

C:\Users\drowley\pg_src>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

I suspect drongo will also show the same warning once it runs on the
latest commit shortly.

David