Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsBWS-00GFNG-VL for pgsql-committers@arkaria.postgresql.org; Wed, 12 Mar 2025 02:08:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tsBWR-00Bbh8-6i for pgsql-committers@arkaria.postgresql.org; Wed, 12 Mar 2025 02:08:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsBWQ-00Bbh0-Vj for pgsql-committers@lists.postgresql.org; Wed, 12 Mar 2025 02:08:38 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tsBWN-002Lpb-1Z for pgsql-committers@lists.postgresql.org; Wed, 12 Mar 2025 02:08:38 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-30bfca745c7so43015221fa.0 for ; Tue, 11 Mar 2025 19:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741745315; x=1742350115; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gr9VF65v71qmAsdvQvYib43AGR8r0mIirNYnsgoSC/U=; b=X3Nt1RuNy7i8ytf45tKGUv7XXdqLhRsZjk07WY2tJ0ZoNvsqdhFTVpnVXkUAiCM2zv GMRazEMXkfI/BeB86NtLPl8VAFhYAz9wslIzXerPu1MaPGMuJKAx8GDQvxVbL0/vB05c eC3lPcaq8ryP5PV/B30AjPPVH5l0ZV87l7sfm7n41cFd9IZgPKQTG+8sr2ZW+JNPVWo1 BBVQmAtrV36t9l3rDAB7c8YCDPZfxe7nOg+tdzHRVJr6CmLSU1qb+oqfAtjPMQgmwhyG sXsL/qo+KvaPndNXU+hDeoHlcNQIP/fA5pR2CR6NcL1Y2ySYZiAzV5aiHmdv/CzJn2Rr OiRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741745315; x=1742350115; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gr9VF65v71qmAsdvQvYib43AGR8r0mIirNYnsgoSC/U=; b=Hzm6l3HHQhJWQPy8sTwnBUyyejfSAWPhaATofylm3vAzlsr/u2tHTiwsswQVfYlXiy Qr1dRcKdB63ra9BhJ3lG6Lp/MHLo8QjpzXmkXbrLdZ9Qhyn5q5BS2UYQa04xANmcsK8W QrKQhFNpunjM/u6DzOCTcW3ks96s+Msw2HVR8IzYCo0G8om8C5wOso84NMLhlA+BfyO7 te+UxbNygAahy/mkVaTKghRwYznmqbia9Uru7svDFQxR+V8cgldycruSr1ZtizQaq4Kk q9i95V2HeyVA6yZCfZZAVQqMZLDJk0AwS/wZxY5ZA+Ezuf66drK4MLTaH+eUsq64WN8h GZGg== X-Gm-Message-State: AOJu0YxmVm728UCWU9r2gg0XDR0dvwj61hrIya8K2aAkMJz2AvHRt9Pr PyuYctyBOciZsVs8LYerj2tB8SUP3X3rPe6efXObwX2PgNvrQkhHmBAFUwuGVydusQEJ/9rCuIW 1/a89j544mjxyU1xp148oDEC6h9gKNw== X-Gm-Gg: ASbGncuK/ZGo1XISR6PEuCgBYJTuHt/lJi/yS1YhL3kr6U4pstlsTrKNLEmgpCNqQOu 81FKjY1ouZwNUqN3diUWG1FZlJCMte/l6Jy/ZlZjplN2kFCE8cIyf/b/Dcp1bItBO0MG9bOIVey WqeForTvwmV8Dboa1ImyoZC8+1lbL1WRD191gAZziac5y9UzyXhpQDdgwMDYNS X-Google-Smtp-Source: AGHT+IGrS9zjNfSOeZyEMf9B0VZZKOB1riQvufWqU7GjWyHzswpjUupID6Bwse1b5WbfDUwfHSlotmBICH2j8EiV9bo= X-Received: by 2002:a19:4342:0:b0:549:43f2:8e53 with SMTP id 2adb3069b0e04-54990e5da8fmr5477940e87.20.1741745314305; Tue, 11 Mar 2025 19:08:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Rowley Date: Wed, 12 Mar 2025 15:08:22 +1300 X-Gm-Features: AQ5f1Jrkx6wJjhxapIQZkQrixO_rIKenHNYe1DrX69od52Rmctca-SecSCOkZT4 Message-ID: Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p To: Masahiko Sawada Cc: pgsql-committers@lists.postgresql.org Content-Type: multipart/mixed; boundary="000000000000bfc83306301baea0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000bfc83306301baea0 Content-Type: text/plain; charset="UTF-8" On Wed, 12 Mar 2025 at 05:57, Masahiko Sawada wrote: > contrib/pg_logicalinspect/pg_logicalinspect.c | 55 ++++++++++++--- This introduces a new compiler warning for compilers that don't know the ereport(ERROR) does not return. The attached is enough to fix it. David --000000000000bfc83306301baea0 Content-Type: application/octet-stream; name="fix_parse_snapshot_filename_warning.patch" Content-Disposition: attachment; filename="fix_parse_snapshot_filename_warning.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m85a5nkl0 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfbG9naWNhbGluc3BlY3QvcGdfbG9naWNhbGluc3BlY3Qu YyBiL2NvbnRyaWIvcGdfbG9naWNhbGluc3BlY3QvcGdfbG9naWNhbGluc3BlY3QuYwppbmRleCAz YjY0ZDhhZDg4MC4uMTNmOWJkYTk0NTkgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcGdfbG9naWNhbGlu c3BlY3QvcGdfbG9naWNhbGluc3BlY3QuYworKysgYi9jb250cmliL3BnX2xvZ2ljYWxpbnNwZWN0 L3BnX2xvZ2ljYWxpbnNwZWN0LmMKQEAgLTg1LDYgKzg1LDggQEAgcGFyc2Vfc25hcHNob3RfZmls ZW5hbWUoY29uc3QgY2hhciAqZmlsZW5hbWUpCiBwYXJzZV9lcnJvcjoKIAllcmVwb3J0KEVSUk9S LAogCQkJZXJybXNnKCJpbnZhbGlkIHNuYXBzaG90IGZpbGUgbmFtZSBcIiVzXCIiLCBmaWxlbmFt ZSkpOworCisJcmV0dXJuIDA7CQkJCQkvKiBrZWVwIGNvbXBpbGVyIHF1aWV0ICovCiB9CiAKIC8q Cg== --000000000000bfc83306301baea0--