MIME-Version: 1.0
References: <23209391537822541@iva4-6d7004ac8463.qloud-c.yandex.net>
 <20180924211117.tpwxemzd3372nagj@alvherre.pgsql>
 <CAD21AoAV17jQH6__E8_VQePms4NptX0X50U=98qJ5RNV7au1iw@mail.gmail.com>
 <20181002001151.GP11712@paquier.xyz>
 <CAD21AoB-nhVxo=6__BeukNniHnt6UGMKRs3v=Zkn-WJq9kx+4A@mail.gmail.com>
 <20181002065508.GC17642@paquier.xyz> <338.1538489728@sss.pgh.pa.us>
In-Reply-To: <338.1538489728@sss.pgh.pa.us>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Wed, 3 Oct 2018 16:37:29 +0900
Message-ID: 
 <CAD21AoBR+y31ps+=G6_fxxVd_o1itTnaK19sDAEhAP_RyVT2AA@mail.gmail.com>
Subject: Re: pgsql: Improve autovacuum logging for aggressive and
 anti-wraparound ru
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
	Sergei Kornilov <sk@zsrv.org>, nasbyj@amazon.com,
 Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c5c94e05774e230b"
Precedence: bulk

--000000000000c5c94e05774e230b
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 2, 2018 at 11:15 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Michael Paquier <michael@paquier.xyz> writes:
> > My brain is rather fried for the rest of the day...  But we could just
> > be looking at using USE_ASSERT_CHECKING.  Thoughts from other are
> > welcome.
>
> I'd go with folding the condition into a plain Assert.  Then it's
> obvious that no code is added in a non-assert build.  I can see that
> some cases might be so complicated that that isn't nice, but this
> case doesn't seem to qualify.
>

Thank you for the comment. Attached the updated patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--000000000000c5c94e05774e230b
Content-Type: application/octet-stream; name="fix_autovacuum_log_v2.patch"
Content-Disposition: attachment; filename="fix_autovacuum_log_v2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jmsua38z0>
X-Attachment-Id: f_jmsua38z0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3ZhY3V1bWxhenkuYyBiL3NyYy9iYWNr
ZW5kL2NvbW1hbmRzL3ZhY3V1bWxhenkuYwppbmRleCA4OTk2ZDM2Li43NjlmZDBlIDEwMDY0NAot
LS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy92YWN1dW1sYXp5LmMKKysrIGIvc3JjL2JhY2tlbmQv
Y29tbWFuZHMvdmFjdXVtbGF6eS5jCkBAIC0yNDksNiArMjQ5LDEwIEBAIGxhenlfdmFjdXVtX3Jl
bChSZWxhdGlvbiBvbmVyZWwsIGludCBvcHRpb25zLCBWYWN1dW1QYXJhbXMgKnBhcmFtcywKIAlp
ZiAob3B0aW9ucyAmIFZBQ09QVF9ESVNBQkxFX1BBR0VfU0tJUFBJTkcpCiAJCWFnZ3Jlc3NpdmUg
PSB0cnVlOwogCisJLyogU2FuaXR5IGNoZWNrOiBhbiBhbnRpLXdyYXBhcm91bmQgdmFjdXVtIG11
c3QgYmUgYW4gYWdncmVzc2l2ZSB2YWN1dW0gKi8KKwlpZiAocGFyYW1zLT5pc193cmFwYXJvdW5k
KQorCQlBc3NlcnQoYWdncmVzc2l2ZSk7CisKIAl2YWNyZWxzdGF0cyA9IChMVlJlbFN0YXRzICop
IHBhbGxvYzAoc2l6ZW9mKExWUmVsU3RhdHMpKTsKIAogCXZhY3JlbHN0YXRzLT5vbGRfcmVsX3Bh
Z2VzID0gb25lcmVsLT5yZF9yZWwtPnJlbHBhZ2VzOwpAQCAtMzc2LDEwICszODAsOCBAQCBsYXp5
X3ZhY3V1bV9yZWwoUmVsYXRpb24gb25lcmVsLCBpbnQgb3B0aW9ucywgVmFjdXVtUGFyYW1zICpw
YXJhbXMsCiAJCQlpbml0U3RyaW5nSW5mbygmYnVmKTsKIAkJCWlmIChwYXJhbXMtPmlzX3dyYXBh
cm91bmQpCiAJCQl7Ci0JCQkJaWYgKGFnZ3Jlc3NpdmUpCi0JCQkJCW1zZ2ZtdCA9IF8oImF1dG9t
YXRpYyBhZ2dyZXNzaXZlIHZhY3V1bSB0byBwcmV2ZW50IHdyYXBhcm91bmQgb2YgdGFibGUgXCIl
cy4lcy4lc1wiOiBpbmRleCBzY2FuczogJWRcbiIpOwotCQkJCWVsc2UKLQkJCQkJbXNnZm10ID0g
XygiYXV0b21hdGljIHZhY3V1bSB0byBwcmV2ZW50IHdyYXBhcm91bmQgb2YgdGFibGUgXCIlcy4l
cy4lc1wiOiBpbmRleCBzY2FuczogJWRcbiIpOworCQkJCS8qIGF1dG92YWN1dW0gY2Fubm90IGJl
IGFudGktd3JhcGFyb3VuZCBhbmQgbm90IGFnZ3Jlc3NpdmUgdmFjdXVtICovCisJCQkJbXNnZm10
ID0gXygiYXV0b21hdGljIGFnZ3Jlc3NpdmUgdmFjdXVtIHRvIHByZXZlbnQgd3JhcGFyb3VuZCBv
ZiB0YWJsZSBcIiVzLiVzLiVzXCI6IGluZGV4IHNjYW5zOiAlZFxuIik7CiAJCQl9CiAJCQllbHNl
CiAJCQl7Cg==
--000000000000c5c94e05774e230b--