MIME-Version: 1.0
References: <E1wSIm8-001NOT-1v@gemulon.postgresql.org>
 <CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Wed, 27 May 2026 15:55:11 -0700
Message-ID: 
 <CAD21AoBVYs+Ob4aBHS3DKxw=2AKW_s7tjUURo4YrQig1vN-Bug@mail.gmail.com>
Subject: Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoBVYs%2BOb4aBHS3DKxw%3D2AKW_s7tjUURo4YrQig1vN-Bug%40mail.gmail.com>
Precedence: bulk

On Wed, May 27, 2026 at 1:09=E2=80=AFPM Alexander Korotkov <aekorotkov@gmai=
l.com> wrote:
>
> Hi!
>
> On Wed, May 27, 2026 at 9:14=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kur=
ilemu.de> wrote:
> > Disable logical decoding after REPACK (CONCURRENTLY)
> >
> > REPACK (CONCURRENTLY) uses a temporary logical replication slot, which
> > is dropped once done, but it wasn't calling RequestDisableLogicalDecodi=
ng(),
> > leaving effective_wal_level stuck at 'logical'.
> >
> > Fix by adding a Boolean flag to ReplicationSlotDropAcquired() to have i=
t
> > request to disable logical decoding, and passing it as true on REPACK.
> > Other callers of that function preserve their existing behavior.
> >
> > Author: Imran Zaheer <imran.zhir@gmail.com>
> > Reviewed-by: shveta malik <shveta.malik@gmail.com>
> > Discussion: https://postgr.es/m/CA+UBfaktds57dw2M8BEv_kS-=3Dixph3w+3MxK=
ixtaDQMi_k7Ybg@mail.gmail.com
>
> This seams to cause buildfarm failures, for instance
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dloach&dt=3D2026=
-05-27%2018%3A25%3A00
>

I've just pushed the fix (47ad2233fad) and hope it makes buildfarm
members happy.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com