MIME-Version: 1.0
References: <E1tlXde-000VTE-1s@gemulon.postgresql.org>
 <CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Mon, 17 Mar 2025 15:01:43 -0700
Message-ID: 
 <CAD21AoCB3CORap1fYVHUiAAuK7t9LGGoYqr1hm-2-LP3DR63uw@mail.gmail.com>
Subject: Re: pgsql: pg_upgrade: Preserve default char signedness value from
 old clus
To: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <msawada@postgresql.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003595ef063090f173"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoCB3CORap1fYVHUiAAuK7t9LGGoYqr1hm-2-LP3DR63uw%40mail.gmail.com>
Precedence: bulk

--0000000000003595ef063090f173
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 17, 2025 at 10:20=E2=80=AFAM Robert Haas <robertmhaas@gmail.com=
> wrote:
>
> On Fri, Feb 21, 2025 at 1:20=E2=80=AFPM Masahiko Sawada <msawada@postgres=
ql.org> wrote:
> > pg_upgrade: Preserve default char signedness value from old cluster.
>
> Hi,
>
> I noticed that after running 'meson test --suite setup --suite
> pg_upgrade', the file delete_old_cluster.sh is left behind in the
> source directory, which should not happen. Everything created for the
> tests should be created in the meson directories. I traced the problem
> down to 005_char_signedness.pl. I believe the problem is likely that
> other pg_upgrade TAP tests include this locution, whereas
> 005_char_signedness.pl does not:
>
> # In a VPATH build, we'll be started in the source directory, but we want
> # to run pg_upgrade in the build directory so that any files generated fi=
nish
> # in it, like delete_old_cluster.{sh,bat}.
> chdir ${PostgreSQL::Test::Utils::tmp_check};

Thank you for the report.

I've confirmed the issue and attached a patch to fix it.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

--0000000000003595ef063090f173
Content-Type: application/octet-stream;
	name="0001-Fix-the-test-005_char_signedness.patch"
Content-Disposition: attachment;
	filename="0001-Fix-the-test-005_char_signedness.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m8dlzya20>
X-Attachment-Id: f_m8dlzya20

RnJvbSA2ZmUxNTc4YmNiZjdmNTc5ODY5Njg0YTcxZGQ0NjNiYjI5MzlkODJjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlrbyBTYXdhZGEgPHNhd2FkYS5tc2hrQGdtYWlsLmNv
bT4KRGF0ZTogTW9uLCAxNyBNYXIgMjAyNSAxNDo1MjoxMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd
IEZpeCB0aGUgdGVzdCAwMDVfY2hhcl9zaWduZWRuZXNzLgoKcGdfdXBncmFkZSB0ZXN0IDAwM19j
aGFyX3NpZ25lZG5lc3Mgd2FzIGxlYXZpbmcgZmlsZXMgbGlrZQpkZWxldGVfb2xkX2NsdXN0ZXIu
c2ggaW4gdGhlIHNvdXJjZSBkaXJlY3RvcnkgZm9yIFZQQVRIIGFuZCBtZXNvbgpidWlsZHMuIFRo
ZSBmaXggaXMgdG8gY2hhbmdlIHRoZSBkaXJlY3RvcnkgdG8gdG1wX2NoZWNrIGJlZm9yZSBydW5u
aW5nCnRoZSB0ZXN0LgoKUmVwb3J0ZWQtYnk6IFJvYmVydCBIYWFzIDxyb2JlcnRtaGFhc0BnbWFp
bC5jb20+ClJldmlld2VkLWJ5OgpEaXNjdXNzaW9uOiBodHRwOi8vcG9zdGdyLmVzL20vQ0ErVGdt
b1lnNWU0b3pubjBYR29KMyttY2VHMXFlX0pKdDM0ckYySkx3dkdTNVQxaGdRQG1haWwuZ21haWwu
Y29tCi0tLQogc3JjL2Jpbi9wZ191cGdyYWRlL3QvMDA1X2NoYXJfc2lnbmVkbmVzcy5wbCB8IDUg
KysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMv
YmluL3BnX3VwZ3JhZGUvdC8wMDVfY2hhcl9zaWduZWRuZXNzLnBsIGIvc3JjL2Jpbi9wZ191cGdy
YWRlL3QvMDA1X2NoYXJfc2lnbmVkbmVzcy5wbAppbmRleCAwMTkwNzQ3NzU4Yy4uMTdmYTBkNDhi
MTUgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfdXBncmFkZS90LzAwNV9jaGFyX3NpZ25lZG5lc3Mu
cGwKKysrIGIvc3JjL2Jpbi9wZ191cGdyYWRlL3QvMDA1X2NoYXJfc2lnbmVkbmVzcy5wbApAQCAt
NDUsNiArNDUsMTEgQEAgY29tbWFuZF9saWtlKAogCXFyL0RlZmF1bHQgY2hhciBkYXRhIHNpZ25l
ZG5lc3M6XHMrdW5zaWduZWQvLAogCSd1cGRhdGVkIGRlZmF1bHQgY2hhciBzaWduZWRuZXNzIGlz
IHVuc2lnbmVkIGluIGNvbnRyb2wgZmlsZScpOwogCisjIEluIGEgVlBBVEggYnVpbGQsIHdlJ2xs
IGJlIHN0YXJ0ZWQgaW4gdGhlIHNvdXJjZSBkaXJlY3RvcnksIGJ1dCB3ZSB3YW50CisjIHRvIHJ1
biBwZ191cGdyYWRlIGluIHRoZSBidWlsZCBkaXJlY3Rvcnkgc28gdGhhdCBhbnkgZmlsZXMgZ2Vu
ZXJhdGVkIGZpbmlzaAorIyBpbiBpdCwgbGlrZSBkZWxldGVfb2xkX2NsdXN0ZXIue3NoLGJhdH0u
CitjaGRpciAke1Bvc3RncmVTUUw6OlRlc3Q6OlV0aWxzOjp0bXBfY2hlY2t9OworCiAjIENhbm5v
dCB1c2UgLS1zZXQtY2hhci1zaWduZWRuZXNzIG9wdGlvbiBmb3IgdXBncmFkaW5nIGZyb20gdjE4
KwogY29tbWFuZF9jaGVja3NfYWxsKAogCVsKLS0gCjIuNDMuNQoK
--0000000000003595ef063090f173--