Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuOgj-0085fq-Ax for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 04:36:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tuOgh-007Re4-Rw for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 04:36:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuOgh-007Rdw-Hx for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 04:36:23 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tuOgd-003Uku-2l for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 04:36:23 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-54993c68ba0so5426093e87.2 for ; Mon, 17 Mar 2025 21:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742272580; x=1742877380; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oRSWd2pMyuzfE4zqP96p4TLQ0Vbsj7r9whF+M1iD0l8=; b=J8UpyKOrsrM5V4eWKWdktobqHGiCD4Mz1Ai3cUqmAir3n+YLcOd51goLtwae59dNE4 1eFWtVN7y8vJ88VhNlK5nM6k5upNS4nUnuhm3Wj+KY/KXdIV2Jjazk35+3Sp0v+500uh nMzThOyQkIc4Z+bOJdweEP3Ak7ScIdnVcLBozQj46drY0eX54E+4lzoHurbziJ2D6u4P nMIFpYc4iw17UyCiQ8Dpr6RQ/rFhYnxC4SJOp5kIoQAMahCQRGAu0v8qn1g+Qz31mhu1 gPPITgCgbQjuEq2QjjPW6XOOGSyu6a5vgl5sESee1YyMndJsqiDrn7GRVBHZv/5yLhAc Vy5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742272580; x=1742877380; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oRSWd2pMyuzfE4zqP96p4TLQ0Vbsj7r9whF+M1iD0l8=; b=wmY6Dlpenp6k+eJQUsml05CffjzcM9zpzMxad1JHzWPsF0aOQCFt6EaV3Rxhf5d0vf rrEed1mJvXKNbpWHPyt5ViN5NK2n10gl1u1tkP8lYAa4CAG+fGK1mIliY7GHx2mu6lno H5eO3c0/Wk9BE256ImzVZ78ujTSQpDd14yn9RVa0igunL+UuYhHqZKYjmjTVH26ywpTC nMkoiqC82JQWT7JjOz9ZXDcVMkhFLIYDIoMwvBPmMDJ3PV5bzl5Nn5oj5i5SGnpoLSuN fcFb+7q02IEwerqBjJrENKxC6iwBJBi72b/ooCEtyqVzzz+9Bxw2tMxY3d/Du8Ifg+h4 pJWA== X-Forwarded-Encrypted: i=1; AJvYcCWRV2sARHwxTwTwOTBONwN9/ft8fFs4LiLo9CWZqtfNhIVeeXrM8p96SCo+Zqe9k1OXdqQK7PuLaigKHAr+@lists.postgresql.org X-Gm-Message-State: AOJu0YxW3UQ4cOsDBz9RP+huc3nQ79MU8vRYlbQPrXq5P/qIEmIotV+A xdPQ0TjMrTdNMjXKizoeWwnmnCm757FyUfgtmM9kpSvabEa+aI5PCVpBkmOs1k7dUbDC1F+Ver2 tH5MvBUQLgRpl1jFJjirUceybpqE= X-Gm-Gg: ASbGncslLArhMAGRHGRuuXmqhl7ky3N29M+b/hrfgwAP5CFWIBLBrD+xo+5mOPQuaB4 B9sSwtnpj6efispgUpAbJakN/8FZIoUtxk54x5ebPjXsVdsEvK/TdPtj22hfmKE8DXnrC/w/+H2 9DCMMhOA8Y5/EgvQAEFP62vrcQYlWHbM7ebkQIJzMnzocJQk1cLXVo48TEqQ== X-Google-Smtp-Source: AGHT+IHwyQjv/efO/iU+SdI1qpa8AIw1t6O+wD+xRP7mbi6KvqqZMB7BdCvzQvtSf9lqBi6gfltQ/As/qZebEDDgkuU= X-Received: by 2002:a05:6512:31cc:b0:549:7145:5d2f with SMTP id 2adb3069b0e04-549c3989959mr9606427e87.33.1742272580093; Mon, 17 Mar 2025 21:36:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Masahiko Sawada Date: Mon, 17 Mar 2025 21:35:43 -0700 X-Gm-Features: AQ5f1JpG-rFWMC5usD5n5xg59jzgpkKG7kppN2rVBZbzJE5OygATxUGOgLGCz9c Message-ID: Subject: Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus To: Robert Haas Cc: Masahiko Sawada , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Mar 17, 2025 at 8:02=E2=80=AFPM Robert Haas = wrote: > > On Mon, Mar 17, 2025 at 6:02=E2=80=AFPM Masahiko Sawada wrote: > > I've confirmed the issue and attached a patch to fix it. > > Cool. The commit message refers to 003_char_signedness, but the test > name is 005, not 003. Thank you for reviewing the patch. I've pushed the patch after fixing it. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com