MIME-Version: 1.0
References: <E1ts2ug-001xVQ-04@gemulon.postgresql.org>
 <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
In-Reply-To: 
 <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Tue, 11 Mar 2025 21:56:14 -0700
Message-ID: 
 <CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY+f4bEK5wNkw@mail.gmail.com>
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a
 directory p
To: David Rowley <dgrowleyml@gmail.com>
Cc: Masahiko Sawada <msawada@postgresql.org>,
 pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY%2Bf4bEK5wNkw%40mail.gmail.com>
Precedence: bulk

On Tue, Mar 11, 2025 at 7:08=E2=80=AFPM David Rowley <dgrowleyml@gmail.com>=
 wrote:
>
> On Wed, 12 Mar 2025 at 05:57, Masahiko Sawada <msawada@postgresql.org> wr=
ote:
> > contrib/pg_logicalinspect/pg_logicalinspect.c      | 55 ++++++++++++---
>
> This introduces a new compiler warning for compilers that don't know
> the ereport(ERROR) does not return.
>
> The attached is enough to fix it.

Thank you for the report. Can we generate the warning using some gcc's
warning flags? I'd like to add a check to my personal pre-commit test.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com